From b068546b5932211fcc04c360fa722849c56ca5bf Mon Sep 17 00:00:00 2001
From: Orazio Battaglia <orazio.battaglia@unibo.it>
Date: Fri, 18 Aug 2023 11:11:08 +0200
Subject: [PATCH] join.pp: added ad_testjoin_command parameter

When a vm is joined using a specific domain controller, the testjoin command will use the same domain controller. This iu useful when not all domain controllers are reachable by the vm, often for firewall reasons
---
 manifests/join.pp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/manifests/join.pp b/manifests/join.pp
index 361cea5..a3964ed 100644
--- a/manifests/join.pp
+++ b/manifests/join.pp
@@ -32,8 +32,10 @@
   else {
     if $ad_join_domain_controller != undef {
       $ad_join_domain_controller_command = " --domain-controller='${ad_join_domain_controller}'"
+      $ad_testjoin_command = "-D ${ad_domain} -S ${ad_join_domain_controller}"
     } else {
       $ad_join_domain_controller_command = ''
+      $ad_testjoin_command = "-D ${ad_domain}"
     }
     if $ad_join_service_names != [] {
         $ad_join_service_names_command = join([" --service-name='", join($ad_join_service_names, "' --service-name='"), "'"], '')
@@ -66,7 +68,7 @@
 --stdin-password --verbose ${ad_join_os_command} ${ad_join_os_version_command} ${ad_join_os_service_pack_command} \
 ${ad_join_service_names_command}",
       logoutput => true,
-      unless    => "/usr/sbin/adcli testjoin -D ${ad_domain}",
+      unless    => "/usr/sbin/adcli testjoin $ad_testjoin_command",
     }
   }
 }