From 18ce7d5e83b9bba7d00934fdb912f548c2b48050 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 15 Nov 2022 19:04:45 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- setup.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 8af9ede..dade85d 100644 --- a/setup.py +++ b/setup.py @@ -33,7 +33,26 @@ def compile_stan_code(): # extract the source file temp_dir = tempfile.TemporaryDirectory() with tarfile.open(filename) as f: - f.extractall(temp_dir.name) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, temp_dir.name) # compile CmdStan proc = subprocess.run(['make','build'],cwd=os.path.join(temp_dir.name,'cmdstan-%s'%(latest_version.replace('v',''))),stdout=sys.stdout,stderr=sys.stderr)