Leftover %S for addresses

[iMusicJJ]

Hey,

It looks like the formatter some countries is a little off.
I've seen it for Italy and Spain with a Danish locale.

Below is the format for Italy for example:

"fmt":"%N%n%O%n%A%n%Z %C %S"

As far as I can tell, it is leaving the %S leftover.

It could be happening to other locales as well.

We are using the package as such:

$formatter = new AddressFormat\Format();

$formatter->setLocale($locale ?? $address->country->iso);

$formatter['ADMIN_AREA'] = $address->state;
$formatter['LOCALITY'] = $address->city;
$formatter['RECIPIENT'] = trim($address->name . "\n" . $address->att);
$formatter['ORGANIZATION'] = $address->company;
$formatter['POSTAL_CODE'] = $address->zip;
$formatter['STREET_ADDRESS'] = trim($address->street . "\n" . $address->street2);

$formatted = $formatter->formatAddress() . "\n" . $address->country->caption($lang);

It seems to have happened after upgrading from 1.5.0 to 2.0.0 - and I can confirm, downgrading to 1.5.0 fixes the issue.

[iMusicJJ]

My hunch said this was the issue:

1.5.0...2.0.0#diff-bc5c0664af2ee1c791c30170379b9a7ea2d42aae0b8b1cdd0e06bcb363c68573R104

And removing the appended . '%n' fixed the issue. It's simply because the system no longer sees the standalone %S, unless it is followed by %n

[adamlc]

Thanks for reporting @iMusicJJ. I guess this is probably due to #24.

Unfortunately I don't really have the capacity to look into this as I no longer use PHP or do any development work. But I am happy to merge a pull requests with some tests fixing the issue.

[iMusicJJ]

Alright, let me start by pinging the author of #24 to see if they want to fix it: @jmslbam

Otherwise it should be a relatively easy and small patch:

1. Restore original functionality by returning the replacement search-pattern to simply $key.
2. Remove excess newlines with trim, instead of a required extra token in the replace search-pattern.

[jmslbam]

Hi! My client pinged me about a similiar issue last week.

It's the spaces infront of the %Z keys. In my Dutch env the issue came to light when my client left out the country %C.

I solved this regression yesterday evening in my own project and ran it on production there.

reiscompany@ba1d472

I will create a PR with more tests and different locales to test, I hope tomorrow, otherwise somewhere this week!

[iMusicJJ]

Hey @jmslbam - what's the timeline on this? If it's not anything in the near future, I'd prefer it if you could add a failing test, and I'll create a fix in the existing PR.

[jmslbam]

Hi @iMusicJJ Thank yo for picking it up! I was totally swamped here. I did get the fix out here on my branch but wasn't able yet to open the PR.

https://github.com/reiscompany/address-format