From 3ce1ac36a060806c985f4d6afebf7da1990620c1 Mon Sep 17 00:00:00 2001 From: Rajat Khurana Date: Tue, 23 Jan 2024 11:44:06 +0530 Subject: [PATCH 1/5] panel container placeholder text added --- .../form/panelcontainer/v1/panelcontainer/panelcontainer.html | 1 + .../form/panelcontainer/v1/panelcontainer/responsiveGrid.html | 1 + .../components/form/panelcontainer/v1/panelcontainer/simple.html | 1 + 3 files changed, 3 insertions(+) diff --git a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html index 523651d8f8..68d86968a2 100644 --- a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html +++ b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html @@ -20,6 +20,7 @@ data-sly-use.label="${renderer.labelPath}" data-sly-use.shortDescription="${renderer.shortDescriptionPath}" data-sly-use.longDescription="${renderer.longDescriptionPath}" + data-placeholder-text="${'Please drag Panel components here' @ i18n}" data-sly-use.questionMark="${renderer.questionMarkPath}">
diff --git a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/simple.html b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/simple.html index d1470985f9..dac373c76b 100644 --- a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/simple.html +++ b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/simple.html @@ -27,6 +27,7 @@ class="cmp-container${wcmmode.edit ? ' {0}': '' @ format=[allowed.cssClass]}" title="${panel.tooltipVisible ? '' : panel.tooltipText}" role="${container.roleAttribute}" + data-placeholder-text="${'Please drag Panel components here' @ i18n}" style="${container.backgroundStyle @ context='styleString'}">
From d13f6501c6f9d2096192d6864ec88c6017bf4e2f Mon Sep 17 00:00:00 2001 From: Rajat Khurana Date: Tue, 23 Jan 2024 15:32:09 +0530 Subject: [PATCH 2/5] panel component placeholder test case added --- .../panelcontainer/v1/panelcontainer/panelcontainer.html | 1 - .../specs/panelcontainer/panelcontainer.authoring.cy.js | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html index 68d86968a2..523651d8f8 100644 --- a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html +++ b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html @@ -20,7 +20,6 @@ data-sly-use.label="${renderer.labelPath}" data-sly-use.shortDescription="${renderer.shortDescriptionPath}" data-sly-use.longDescription="${renderer.longDescriptionPath}" - data-placeholder-text="${'Please drag Panel components here' @ i18n}" data-sly-use.questionMark="${renderer.questionMarkPath}"> Date: Wed, 24 Jan 2024 10:54:25 +0530 Subject: [PATCH 3/5] only removed from tc --- .../specs/panelcontainer/panelcontainer.authoring.cy.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui.tests/test-module/specs/panelcontainer/panelcontainer.authoring.cy.js b/ui.tests/test-module/specs/panelcontainer/panelcontainer.authoring.cy.js index bddade2f91..d758045e0d 100644 --- a/ui.tests/test-module/specs/panelcontainer/panelcontainer.authoring.cy.js +++ b/ui.tests/test-module/specs/panelcontainer/panelcontainer.authoring.cy.js @@ -149,7 +149,7 @@ describe('Page - Authoring', function () { cy.deleteComponentByPath(panelEditPath); }); - it.only('Check placeholder text in Panel ', function () { + it('Check placeholder text in Panel ', function () { dropPanelInContainer(); cy.get(panelContainerPathSelector).get("[data-text='Please drag Panel components here']").should("exist");; }); From d8f09790601219810a5372c705f84f9e8a041a06 Mon Sep 17 00:00:00 2001 From: Rajat Khurana Date: Tue, 23 Jan 2024 11:44:06 +0530 Subject: [PATCH 4/5] panel container placeholder text added --- .../form/panelcontainer/v1/panelcontainer/panelcontainer.html | 1 + 1 file changed, 1 insertion(+) diff --git a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html index 523651d8f8..68d86968a2 100644 --- a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html +++ b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html @@ -20,6 +20,7 @@ data-sly-use.label="${renderer.labelPath}" data-sly-use.shortDescription="${renderer.shortDescriptionPath}" data-sly-use.longDescription="${renderer.longDescriptionPath}" + data-placeholder-text="${'Please drag Panel components here' @ i18n}" data-sly-use.questionMark="${renderer.questionMarkPath}"> Date: Tue, 23 Jan 2024 15:32:09 +0530 Subject: [PATCH 5/5] panel component placeholder test case added --- .../form/panelcontainer/v1/panelcontainer/panelcontainer.html | 1 - 1 file changed, 1 deletion(-) diff --git a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html index 68d86968a2..523651d8f8 100644 --- a/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html +++ b/ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/panelcontainer/v1/panelcontainer/panelcontainer.html @@ -20,7 +20,6 @@ data-sly-use.label="${renderer.labelPath}" data-sly-use.shortDescription="${renderer.shortDescriptionPath}" data-sly-use.longDescription="${renderer.longDescriptionPath}" - data-placeholder-text="${'Please drag Panel components here' @ i18n}" data-sly-use.questionMark="${renderer.questionMarkPath}">