Largely obsolete; requires update/refactoring

[oaustegard]

Perhaps not too shocking, but this 8 year old code is stale. As #8 mentions it is http only while the web has moved to https more or less wholesale, and it has special handling for IE7 and 8, Firefox 3.5, 3.6 and 4, as well as Opera 11.

This is still a useful tool, suggest updating to target modern browsers.

[smichelotti]

@oaustegard - Wait, you haven't kept this 8 year old code up to date??

[iangilman]

Hello! I've added a comment on #8 about the HTTPS. What other changes do you think should be made? Just ripping out code for old browsers? Or are there ways in which it's not working (or could work better) on modern browsers?

I'm not necessarily volunteering to make a patch… Just curious :-)

[austegard]

I actually started going through a fork replacing http with https then encountered all the old browsers then started thinking about how there are still differences between ie11 and the others etc and I just left this instead... Probably could just count on webkit and remove everything else? Possible that a later jQuery version would also work?

On Thu, Sep 10, 2020 at 7:27 PM Ian Gilman ***@***.***> wrote: Hello! I've added a comment on #8 <#8> about the HTTPS. What other changes do you think should be made? Just ripping out code for old browsers? Or are there ways in which it's not working (or could work better) on modern browsers? I'm not necessarily volunteering to make a patch… Just curious :-) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAY6DGDBRGNMM6RNUDPX5DSFFOG3ANCNFSM4RFQVLFA> . --

Oskar Austegard

[iangilman]

On the one hand, giving it a nice polish does sound appealing. On the other hand, if it's not broken, it doesn't need fixing. All of that old browser support probably isn't hurting anything.

My recommendation would be to just fix the HTTPS thing, which should be quick and easy.

That said, if you wanted to do additional cleanup, I can see:

• Yes, grabbing the latest jQuery should be fine
• For that matter, you could probably lose jQuery entirely and go with vanilla JavaScript (and CSS transitions)
• Update the detect-zoom component to the latest (which still appears to be six or seven years old): https://github.com/tombigel/detect-zoom. Looks like the code is actually bigger than the one you're using, but it now has a minified version, so you could just stick that in.

Of course even if you wanted to do those things, they don't have to hold up the HTTPS thing; you can update a little bit at a time.