Inconsistent variable logic/usage between Debian/Ubuntu and CentOS/RedHat

[SAL-e]

Looks like currently variables: 'google_agent_pkg_state' and 'google_agent_repository_state' are only effecting Debian based distributions. It is not very clear what is the purpose of them. I can see two possible uses:

1. Cleanup repository after removal of chrome or/and talkplugin; OR
2. Disable automatic updates of Chrome. (I suspect this was the main intent.)

There are two issues with current setup:

1. Google Talk Plugin repository will be added even if 'google_talkplugin_enabled' is set to 'no'.
2. The role will behave completely differently on CentOS/RedHat.

I have some ideas how to fix it, but first I need to better understand the current use in order to provide consistent behavior.

[alourie]

@SAL-e

I don't actually remember why was it introduced, I'll need to refresh my memory for that. I think that the main intent was actually about cleaning up the repos, as I don't have a problem with Chrome updating itself.

Also, I started the work on that more than a year ago, and things have changed since then, so clearly the recipe might need an update. I'd love to see what ideas you have on fixing it.

Thanks!

[SAL-e]

Here is my proposal: SAL-e@7aedc89

I fully tested adding and removing repositories and chrome. I have not tested google talk plugin itself. If you agree with my approach I will fix the yum based tasks as well.