What needs to be done needs to be done

[Wolfolo]

What is NRT missing to be in a trunk-ready state?
See: https://wiki.openttd.org/Frosch/NotRoadTypes#ToDo_list

Features:

• Flag to enable houses along some road- or tramtypes. Disabled for default tramtypes.

Bugfixes:

• Fix scenario editor tramway building
• Electric trams can turn when the catenary ends but the track continues without return loop (is it only a matter of graphics?)

Future:

• Flag for no-junctions
• Make it possible to let towns chose what roadtype they use
  • when to upgrade to a new type?
  • different types based on town zone?
• Disable construction of drive-in stops
• Roadsides
• Underlay
• Shared catenary? Catenary as infrastructure, set for all the roatypes present on the tile, not part of roadtype. A roadtype could set if catenary is allowed?
• NRTBGT (https://wiki.openttd.org/Frosch/ButGroundTypes): Groundtypes instead of roadtypes allow more freedom of customization and reduce a lot the duplication of code in GRFs, as some roadtypes are just eyecandy and don't change the properties.
• Non-constructible rail-/road-/tramtypes to model vehicle compatibility/poweredness

[andythenorth]

"Non-constructible rail-/road-/tramtypes to model vehicle compatibility/poweredness" could be future imho

[Wolfolo]

Moved to future section

[andythenorth]

How to merge to ottd master?

TrueBrain: okay, andythenorth, it is not that bad
[7:27pm] TrueBrain: what I did is this:
[7:28pm] TrueBrain: git rebase --onto origin/master deprecated/master deprecated/road-and-tram-types
[7:28pm] TrueBrain: of the 229 patches it applies
[7:28pm] TrueBrain: only 20 conflict
[7:28pm] TrueBrain: the harest are the ones with grf/png changes (binaries)
[7:28pm] TrueBrain: ~8 of them
[7:28pm] TrueBrain: 2 were MSVC project changes
[7:28pm] TrueBrain: the rest were conflicts even I could resolve
[7:28pm] andythenorth: some of them just needed openttd.grf rebuilt iirc
[7:28pm] TrueBrain: so if someone goes through that slowly, it is done in a few
[7:28pm] TrueBrain: not the fanciest work, but .. it is also not terrible
[7:29pm] TrueBrain: owh, and a dutch.txt conflict and a greek.txt conflict

[PeterN]

In src/road.cpp within function HasRoadTypeAvail()

if (company == OWNER_DEITY || company == OWNER_TOWN || _game_mode == GM_EDITOR || _generating_world) {
return true; // TODO
} else {
...
}

[PeterN]

In src/road.cpp within CleanUpRoadBits()

const RoadBits neighbor_rb = GetAnyRoadBits(neighbor_tile, ROADTYPE_ROAD) | GetAnyRoadBits(neighbor_tile, ROADTYPE_TRAM); // TODO

[PeterN]

In src/company_gui.c within UpdateRailRoadTypes()

this->roadtypes[ROADTYPE_ROAD] = ROADSUBTYPES_NORMAL; // Road is always available. // TODO

[PeterN]

In src/road.cpp within GetCompanyRoadtypes()

if (rt == ROADTYPE_ROAD) rst |= ROADSUBTYPES_NORMAL; // Road is always available. // TODO

[PeterN]

I guess it would be useful to have a road type flag to specify if a roadtype is always available, instead of hardcoding it.

[PeterN]

In src/road_cmd.cpp within CmdBuildRoad()

if (tile == end_tile && !CanConnectToRoad(tile, rtid.basetype, dir)) { // TODO
bits = DiagDirToRoadBits(ReverseDiagDir(dir));
} else if (tile == start_tile && !CanConnectToRoad(tile, rtid.basetype, ReverseDiagDir(dir))) { // TODO
bits = DiagDirToRoadBits(dir);
}

[andythenorth]

Patch from Wolf with better comments for TODOs https://gist.github.com/Wolfolo/c113fa31d6cf81ded843239f17f55541