Sometimes the tests fail (off by 1ms)

[paulbjensen]

Sometimes the tests will fail where the timestamp comparison is off by 1 millisecond.

I could try and make the test assertions more forgiving, but I wonder if this is hinting at a performance issue that ought to be resolved instead.

This is worth digging into at some point

[paulbjensen]

For context, here is the trace from a failed run:

24s
Run npm run cover

> @anephenix/auth@0.0.5 cover
> cross-env NODE_ENV=test npx vitest test --run --coverage --no-file-parallelism


 RUN  v3.2.4 /home/runner/work/auth/auth
      Coverage enabled with v8

 ✓ test/e2e_apps/app_with_auth_and_sessions_implemented/index.test.ts (38 tests) 2283ms
 ✓ test/e2e_apps/app_for_mfa_totp/index.test.ts (14 tests) 4162ms
   ✓ E2E Tests for MFA TOTP > setting up a user to use MFA TOTP > should support the flow of setting up a MFA TOTP for a user  325ms
   ✓ E2E Tests for MFA TOTP > disabling MFA TOTP for a user > should also support the option of disabling MFA TOTP if say the user lost the device they used for MFA TOTP with a recovery code, and is not logged in  466ms
   ✓ E2E Tests for MFA TOTP > generating recovery codes > should support generating recovery codes for a user  646ms
   ✓ E2E Tests for MFA TOTP > generating recovery codes > should prevent generating recovery codes if the user has already generated them	  658ms
 ✓ test/e2e_apps/app_for_forgotten_password_and_reset_password_flows/index.test.ts (28 tests) 1633ms
 ❯ test/index.test.ts (29 tests | 1 failed) 482ms
   ✓ Auth class > should validate passwords correctly 2ms
   ✓ Auth class > Password validation with rules > minLength > should return false for passwords shorter than minLength 0ms
   ✓ Auth class > Password validation with rules > minLength > should return true for passwords equal to or greater than minLength 0ms
   ✓ Auth class > Password validation with rules > maxLength > should return false for passwords longer than maxLength 0ms
   ✓ Auth class > Password validation with rules > maxLength > should return true for passwords equal to or shorter than maxLength 0ms
   ✓ Auth class > Password validation with rules > requireUppercase > should return false for passwords without uppercase letters when required 0ms
   ✓ Auth class > Password validation with rules > requireUppercase > should return true for passwords with uppercase letters when required 0ms
   ✓ Auth class > Password validation with rules > requireLowercase > should return false for passwords without lowercase letters when required 0ms
   ✓ Auth class > Password validation with rules > requireLowercase > should return true for passwords with lowercase letters when required 0ms
   ✓ Auth class > Password validation with rules > requireNumbers > should return false for passwords without numbers when required 0ms
   ✓ Auth class > Password validation with rules > requireNumbers > should return true for passwords with numbers when required 0ms
   ✓ Auth class > Password validation with rules > requireSpecialCharacters > should return false for passwords without special characters when required 0ms
   ✓ Auth class > Password validation with rules > requireSpecialCharacters > should return true for passwords with special characters when required 0ms
   ✓ Auth class > Password validation with rules > should throw an error if passed both a minLength and maxLength that are not compatible 1ms
   ✓ Auth class > hashPassword > should hash a password 55ms
   ✓ Auth class > verifyPassword > should verify a password against a hashed password 89ms
   ✓ Auth class > verifyPassword > should return false for an incorrect password 92ms
   ✓ Auth class > #generateSession > should generate a session with an access token, refresh token, and default expiration times for both tokens 1ms
   ✓ Auth class > #generateSession > should generate a session with custom expiration times if provided in the auth config 1ms
   ✓ Auth class > #generateSession > should generate a session with custom expiration times if provided in the function 0ms
   ✓ Auth class > #generateSession > should generate a session with custom token generators if provided in the auth config 0ms
   ✓ Auth class > #generateTokenAndCode > when using default options > should generate a token, code, and token expiration time of 5 minutes 45ms
   ✓ Auth class > #generateTokenAndCode > when using custom options passed during initialization of auth > should generate a token, code, and token expiration time as defined in the auth config 44ms
   ✓ Auth class > #generateTokenAndCode > when using custom options passed to the function > should generate a token, code, and token expiration time as defined in the function 45ms
   ✓ Auth class > #generateSmsCode > should generate a token, a code, a hashed code, and an expiration time of 5 minutes 46ms
   ✓ Auth class > #generateSmsCode > should use custom smsCodeGenerator if provided in the auth config 45ms
   ✓ Auth class > normalize > should normalize a username by removing all whitespace and converting to lowercase 1ms
   × Auth class > generateMfaLoginToken > when using default options > should generate a token and an expiration time of 30 seconds 10ms
     → expected 2025-10-22T06:32:56.781Z to strictly equal 2025-10-22T06:32:56.782Z
   ✓ Auth class > generateMfaLoginToken > when using custom options passed during initialization of auth > should generate a token and an expiration time as defined in the auth config 0ms
 ✓ test/e2e_apps/app_for_mfa_sms_code/index.test.ts (9 tests) 1206ms
 ✓ test/e2e_apps/app_for_magic_links/index.test.ts (9 tests) 896ms
 ✓ test/e2e_apps/app_for_magic_links/models/MagicLink.test.ts (12 tests) 650ms
 ✓ test/e2e_apps/app_with_auth_and_sessions_implemented/models/User.test.ts (18 tests) 744ms
 ✓ test/e2e_apps/app_for_password_in_separate_table/index.test.ts (8 tests) 608ms
 ✓ test/e2e_apps/app_for_mfa_totp/models/RecoveryCode.test.ts (11 tests) 1210ms
 ✓ test/e2e_apps/app_with_auth_and_sessions_implemented/models/Session.test.ts (16 tests) 148ms
 ✓ test/e2e_apps/app_for_password_in_users_table/index.test.ts (5 tests) 312ms
 ✓ test/e2e_apps/app_for_mfa_sms_code/models/SmsCode.test.ts (2 tests) 182ms
 ✓ test/utils/comparators.test.ts (2 tests) 3ms

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/index.test.ts > Auth class > generateMfaLoginToken > when using default options > should generate a token and an expiration time of 30 seconds
AssertionError: expected 2025-10-22T06:32:56.781Z to strictly equal 2025-10-22T06:32:56.782Z

- Expected
+ Received

- 2025-10-22T06:32:56.782Z
+ 2025-10-22T06:32:56.781Z

 ❯ test/index.test.ts:407:23
    405|     expect(isRandomString(token)).toBe(true);
    406|     expect(expiresAt).toBeInstanceOf(Date);
    407|     expect(expiresAt).toStrictEqual(thirtySecondsFromNow);
       |                       ^
    408|    });
    409|   });

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯


 Test Files  1 failed | 13 passed (14)
      Tests  1 failed | 200 passed (201)
   Start at  06:32:15
   Duration  22.75s (transform 565ms, setup 0ms, collect 4.75s, tests 14.52s, environment 4ms, prepare 1.12s)


Error: AssertionError: expected 2025-10-22T06:32:56.781Z to strictly equal 2025-10-22T06:32:56.782Z

- Expected
+ Received

- 2025-10-22T06:32:56.782Z
+ 2025-10-22T06:32:56.781Z

 ❯ test/index.test.ts:407:23


Error: Process completed with exit code 1.