From 2ce02394870b021402be527823e53364cb8cdab1 Mon Sep 17 00:00:00 2001 From: Jess Moore Date: Fri, 16 Jan 2026 17:38:05 +1100 Subject: [PATCH 1/2] standardised use of colour in permission granting/revoking --- lib/src/solid/constants/ui.dart | 20 +++++++++++++++++++ lib/src/solid/grant_permission_helper.dart | 2 -- lib/src/solid/grant_permission_ui.dart | 6 +++--- .../widgets/file_permission_data_table.dart | 5 +++-- 4 files changed, 26 insertions(+), 7 deletions(-) diff --git a/lib/src/solid/constants/ui.dart b/lib/src/solid/constants/ui.dart index a052bece..5c4034c1 100644 --- a/lib/src/solid/constants/ui.dart +++ b/lib/src/solid/constants/ui.dart @@ -30,6 +30,26 @@ library; import 'package:flutter/material.dart'; +// Standard colours for actions and results. + +class ActionColors { + /// Green colour used for success + + static const success = Colors.green; + + // Red colour used for error/failure + + static const error = Colors.red; + + // Colour used for warning + + static const warning = Color.fromARGB(255, 204, 99, 1); + + // Red colour used for delete action + + static const delete = Colors.red; +} + /// Colours used across security dialogs and prompts. class SecurityColors { diff --git a/lib/src/solid/grant_permission_helper.dart b/lib/src/solid/grant_permission_helper.dart index 373dde94..da34bdaf 100644 --- a/lib/src/solid/grant_permission_helper.dart +++ b/lib/src/solid/grant_permission_helper.dart @@ -108,8 +108,6 @@ void debugPrintFailure( debugPrint(getPermissionMsg(permissionList)); } -const warnBgColor = Color.fromARGB(255, 204, 99, 1); - /// Small vertical spacing for the widget. const smallGapV = SizedBox(height: 10.0); diff --git a/lib/src/solid/grant_permission_ui.dart b/lib/src/solid/grant_permission_ui.dart index 25a9da97..596c1c97 100644 --- a/lib/src/solid/grant_permission_ui.dart +++ b/lib/src/solid/grant_permission_ui.dart @@ -555,7 +555,7 @@ class GrantPermissionUiState extends State } if (result == SolidFunctionCallStatus.success) { - _showSnackBar(successMsg, Colors.green); + _showSnackBar(successMsg, ActionColors.success); await _updatePermissions( dataFile, isFile: getIsFile(), @@ -569,12 +569,12 @@ class GrantPermissionUiState extends State widget.onPermissionGranted?.call(); } else if (result == SolidFunctionCallStatus.fail) { // More detailed error message with troubleshooting tips - _showSnackBar(failureMsg, Colors.red); + _showSnackBar(failureMsg, ActionColors.error); // Also log to console for debugging debugPrintFailure(dataFile, finalWebIdList, selectedPermList); } else if (result == SolidFunctionCallStatus.notInitialised) { - _showSnackBar(podNotInitMsg, warnBgColor); + _showSnackBar(podNotInitMsg, ActionColors.warning); } else { await _alert(updatePermissionMsg); } diff --git a/lib/src/widgets/file_permission_data_table.dart b/lib/src/widgets/file_permission_data_table.dart index 6a915865..3c0dae5b 100644 --- a/lib/src/widgets/file_permission_data_table.dart +++ b/lib/src/widgets/file_permission_data_table.dart @@ -34,6 +34,7 @@ library; import 'package:flutter/material.dart' hide Key; import 'package:solidpod/src/solid/constants/common.dart'; +import 'package:solidpod/src/solid/constants/ui.dart'; import 'package:solidpod/src/solid/constants/web_acl.dart'; import 'package:solidpod/src/solid/revoke_permission.dart'; import 'package:solidpod/src/solid/utils/snack_bar.dart'; @@ -127,7 +128,7 @@ Widget buildPermDataTable({ icon: const Icon( Icons.delete, size: 24.0, - color: Colors.red, + color: ActionColors.delete, ), onPressed: () { showDialog( @@ -164,7 +165,7 @@ Widget buildPermDataTable({ showSnackBar( context, 'Permission revoked successfully!', - Colors.red, + ActionColors.success, ); } await updatePermissionsFunction( From b4dd9656ebe4dd502b0dd7139cb68a99e130564e Mon Sep 17 00:00:00 2001 From: Jess Moore Date: Fri, 16 Jan 2026 17:53:34 +1100 Subject: [PATCH 2/2] updated changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 25b45517..a6ead3ab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ Visit the package at [pub.dev](https://pub.dev/packages/solidpod). ## 0.10 Further UI migrations ++ Standardise action message colors [0.9.9 20260116 jesscmoore] + Support custom folder structure [0.9.8 20260114 anushkavid] + Restore individual recipient suggestions [0.9.7 20260113 jesscmoore] + Allow sharing externally owned files [0.9.6 20260110 jesscmoore]