From c86fe1958039794aae8b7530e0ae5e415516ac7b Mon Sep 17 00:00:00 2001 From: Stanley Idesis Date: Wed, 30 Jan 2019 20:23:47 -0600 Subject: [PATCH] Fixed the Global Variable Names MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The vars are actually capitalized, not camel case as the document suggests. 👍 --- README.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 2c529b3..6709bf3 100644 --- a/README.md +++ b/README.md @@ -47,7 +47,7 @@ define([ 'highlight-share' ], highlightShare => { }); // Global -var highlightShare = window.highlightShare; +var highlightShare = window.HighlightShare; ``` Import any sharers you need: @@ -146,13 +146,13 @@ The following are the default basic sharers provided by the package: Site | File location | Name | Global variable ---------|-----------------------------|-------------|----------------------- -Twitter | `dist/sharers/twitter.js` | `twitter` | `highlightShareViaTwitter` -Facebook | `dist/sharers/facebook.js` | `facebook` | `highlightShareViaFacebook` -Facebook Messenger | `dist/sharers/facebook-messenger.js` | `facebook-messenger` | `highlightShareViaFacebookMessenger` -LinkedIn | `dist/sharers/linked-in.js` | `linked-in` | `highlightShareViaLinkedIn` -Reddit | `dist/sharers/reddit.js` | `reddit` | `highlightShareViaReddit` -Email | `dist/sharers/email.js` | `email` | `highlightShareViaEmail` -Copy | `dist/sharers/copy.js` | `copy` | `highlightShareViaCopy` +Twitter | `dist/sharers/twitter.js` | `twitter` | `HighlightShareViaTwitter` +Facebook | `dist/sharers/facebook.js` | `facebook` | `HighlightShareViaFacebook` +Facebook Messenger | `dist/sharers/facebook-messenger.js` | `facebook-messenger` | `HighlightShareViaFacebookMessenger` +LinkedIn | `dist/sharers/linked-in.js` | `linked-in` | `HighlightShareViaLinkedIn` +Reddit | `dist/sharers/reddit.js` | `reddit` | `HighlightShareViaReddit` +Email | `dist/sharers/email.js` | `email` | `HighlightShareViaEmail` +Copy | `dist/sharers/copy.js` | `copy` | `HighlightShareViaCopy` The list of the sharers is also available on the `sharers` property on the popover element (e.g. passed to the `onOpen` callback), for dynamic runtime handling.