From 64db26d61a457808d1319d11cd0c0657ead82be1 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 10:53:50 -0800 Subject: [PATCH 01/16] Attempt to resolve caching issue with ODBC CI Add write permission to store vcpkg cache --- .github/workflows/cpp_extra.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index ca5a3adb4b7..eae712de57a 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -339,6 +339,8 @@ jobs: contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra') || contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra: C++') timeout-minutes: 240 + permissions: + packages: write env: ARROW_BUILD_SHARED: ON ARROW_BUILD_STATIC: OFF @@ -386,7 +388,7 @@ jobs: run: | echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT - name: Cache ccache - uses: actions/cache@v4 + uses: actions/cache@v5 with: path: ${{ steps.ccache-info.outputs.cache-dir }} key: cpp-odbc-ccache-windows-x64-${{ hashFiles('cpp/**') }} From cb281bf62139e1c071b0399630ce8486a59991ce Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 14:24:30 -0800 Subject: [PATCH 02/16] Check nuget paths in Ruby Glib and ODBC Run vcpkg install after vcpkg is set in GLib --- .github/workflows/cpp_extra.yml | 35 ++++++++++++++++++++------------- .github/workflows/ruby.yml | 7 +++++++ ci/scripts/cpp_build.sh | 4 ++++ 3 files changed, 32 insertions(+), 14 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index eae712de57a..ce7126dea3d 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -420,22 +420,29 @@ jobs: $(vcpkg fetch nuget | tail -n 1) \ setapikey "${{ secrets.GITHUB_TOKEN }}" \ -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" - - name: Build - shell: cmd - run: | - set VCPKG_ROOT_KEEP=%VCPKG_ROOT% - call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 - set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - - name: Register Flight SQL ODBC Driver - shell: cmd + - name: Show vcpkg NuGet + shell: pwsh run: | - call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll - # GH-48270 TODO: Resolve segementation fault during Arrow library unload - # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI - # GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved. + vcpkg fetch nuget + # -AL- temp disable. + # - name: Build + # shell: cmd + # run: | + # set VCPKG_ROOT_KEEP=%VCPKG_ROOT% + # call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 + # set VCPKG_ROOT=%VCPKG_ROOT_KEEP% + # vcpkg install abseil --debug + # bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" + + # - name: Register Flight SQL ODBC Driver + # shell: cmd + # run: | + # call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll + # # GH-48270 TODO: Resolve segementation fault during Arrow library unload + # # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI + # # GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved. - # GH-47787 TODO: Build ODBC installer + # # GH-47787 TODO: Build ODBC installer report-extra-cpp: if: github.event_name == 'schedule' && always() diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 3545f1c16a5..a1b9be5b6e3 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -422,12 +422,19 @@ jobs: $(vcpkg fetch nuget | tail -n 1) \ setapikey "${{ secrets.GITHUB_TOKEN }}" \ -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" + #-AL- for testing, remove later. + - name: Show vcpkg NuGet + shell: pwsh + run: | + vcpkg fetch nuget - name: Build C++ shell: cmd run: | + $env:VCPKG_DEBUG = "1" set VCPKG_ROOT_KEEP=%VCPKG_ROOT% call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 set VCPKG_ROOT=%VCPKG_ROOT_KEEP% + vcpkg install abseil --debug bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - name: Build GLib shell: cmd diff --git a/ci/scripts/cpp_build.sh b/ci/scripts/cpp_build.sh index 904b5cccb42..cd41fa2fef6 100755 --- a/ci/scripts/cpp_build.sh +++ b/ci/scripts/cpp_build.sh @@ -19,6 +19,8 @@ set -ex +export VCPKG_DEBUG=1 #-AL- TEMP + source_dir=${1}/cpp build_dir=${2}/cpp @@ -180,7 +182,9 @@ elif [ -n "${CMAKE_PRESET}" ]; then ${ARROW_CMAKE_ARGS} \ ${source_dir} else +# -AL- added `VCPKG_VERBOSE` for debugging vcpkg cmake \ + -DVCPKG_VERBOSE=ON \ -Dabsl_SOURCE=${absl_SOURCE:-} \ -DARROW_ACERO=${ARROW_ACERO:-OFF} \ -DARROW_AZURE=${ARROW_AZURE:-OFF} \ From c32f2218c3b18ee0c1ebe7caf125d5e41c793368 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 15:32:50 -0800 Subject: [PATCH 03/16] Enable vcpkg verbose in GLib * confirmed `vcpkg install` command returns 403 error --- .github/workflows/cpp_extra.yml | 6 +++++- .github/workflows/ruby.yml | 12 +++++++++--- cpp/cmake_modules/Usevcpkg.cmake | 2 ++ 3 files changed, 16 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index ce7126dea3d..c54ca88ad6e 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -420,10 +420,14 @@ jobs: $(vcpkg fetch nuget | tail -n 1) \ setapikey "${{ secrets.GITHUB_TOKEN }}" \ -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" - - name: Show vcpkg NuGet + - name: Show vcpkg NuGet pwsh shell: pwsh run: | vcpkg fetch nuget + - name: Show vcpkg NuGet bash + shell: bash + run: | + vcpkg fetch nuget # -AL- temp disable. # - name: Build # shell: cmd diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index a1b9be5b6e3..b21637d49f1 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -423,10 +423,14 @@ jobs: setapikey "${{ secrets.GITHUB_TOKEN }}" \ -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" #-AL- for testing, remove later. - - name: Show vcpkg NuGet + - name: Show vcpkg NuGet pwsh shell: pwsh run: | - vcpkg fetch nuget + vcpkg fetch nuget + - name: Show vcpkg NuGet bash + shell: bash + run: | + vcpkg fetch nuget - name: Build C++ shell: cmd run: | @@ -434,7 +438,9 @@ jobs: set VCPKG_ROOT_KEEP=%VCPKG_ROOT% call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - vcpkg install abseil --debug + # -AL- Below line returns 403 error also. + # But somehow the `cpp_build.sh` vcpkg build succeeds. + # vcpkg install abseil --debug bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - name: Build GLib shell: cmd diff --git a/cpp/cmake_modules/Usevcpkg.cmake b/cpp/cmake_modules/Usevcpkg.cmake index 016cfd169e4..a61918235b4 100644 --- a/cpp/cmake_modules/Usevcpkg.cmake +++ b/cpp/cmake_modules/Usevcpkg.cmake @@ -17,6 +17,8 @@ message(STATUS "Using vcpkg to find dependencies") +set(VCPKG_VERBOSE ON CACHE BOOL "-AL- test Enable verbose output from vcpkg") + # ---------------------------------------------------------------------- # Define macros From cb6a294825ceff7054a912355e94a0ce1cce325c Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 15:43:48 -0800 Subject: [PATCH 04/16] Add ARROW_HOME Remove `ARROW_SIMD_LEVEL` as it is not required for ODBC. --- .github/workflows/cpp_extra.yml | 34 ++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index c54ca88ad6e..76830ffe0ab 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -348,7 +348,7 @@ jobs: ARROW_BUILD_TYPE: release ARROW_DEPENDENCY_SOURCE: VCPKG ARROW_FLIGHT_SQL_ODBC: ON - ARROW_SIMD_LEVEL: AVX2 + ARROW_HOME: /usr CMAKE_GENERATOR: Ninja CMAKE_INSTALL_PREFIX: /usr VCPKG_BINARY_SOURCES: 'clear;nuget,GitHub,readwrite' @@ -429,24 +429,24 @@ jobs: run: | vcpkg fetch nuget # -AL- temp disable. - # - name: Build - # shell: cmd - # run: | - # set VCPKG_ROOT_KEEP=%VCPKG_ROOT% - # call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 - # set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - # vcpkg install abseil --debug - # bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" + - name: Build + shell: cmd + run: | + set VCPKG_ROOT_KEEP=%VCPKG_ROOT% + call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 + set VCPKG_ROOT=%VCPKG_ROOT_KEEP% + vcpkg install abseil --debug + bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - # - name: Register Flight SQL ODBC Driver - # shell: cmd - # run: | - # call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll - # # GH-48270 TODO: Resolve segementation fault during Arrow library unload - # # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI - # # GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved. + - name: Register Flight SQL ODBC Driver + shell: cmd + run: | + call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll + # GH-48270 TODO: Resolve segementation fault during Arrow library unload + # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI + # GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved. - # # GH-47787 TODO: Build ODBC installer + # GH-47787 TODO: Build ODBC installer report-extra-cpp: if: github.event_name == 'schedule' && always() From d0bd9f66d9a92d8020c77404196d235c0209cc25 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 16:04:30 -0800 Subject: [PATCH 05/16] Remove debug msgs Cannot get vcpkg in cpp_build to show debug messages --- .github/workflows/cpp_extra.yml | 2 -- ci/scripts/cpp_build.sh | 4 ---- cpp/cmake_modules/Usevcpkg.cmake | 2 -- 3 files changed, 8 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index 76830ffe0ab..e419a7a24c7 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -428,14 +428,12 @@ jobs: shell: bash run: | vcpkg fetch nuget - # -AL- temp disable. - name: Build shell: cmd run: | set VCPKG_ROOT_KEEP=%VCPKG_ROOT% call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - vcpkg install abseil --debug bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - name: Register Flight SQL ODBC Driver diff --git a/ci/scripts/cpp_build.sh b/ci/scripts/cpp_build.sh index cd41fa2fef6..904b5cccb42 100755 --- a/ci/scripts/cpp_build.sh +++ b/ci/scripts/cpp_build.sh @@ -19,8 +19,6 @@ set -ex -export VCPKG_DEBUG=1 #-AL- TEMP - source_dir=${1}/cpp build_dir=${2}/cpp @@ -182,9 +180,7 @@ elif [ -n "${CMAKE_PRESET}" ]; then ${ARROW_CMAKE_ARGS} \ ${source_dir} else -# -AL- added `VCPKG_VERBOSE` for debugging vcpkg cmake \ - -DVCPKG_VERBOSE=ON \ -Dabsl_SOURCE=${absl_SOURCE:-} \ -DARROW_ACERO=${ARROW_ACERO:-OFF} \ -DARROW_AZURE=${ARROW_AZURE:-OFF} \ diff --git a/cpp/cmake_modules/Usevcpkg.cmake b/cpp/cmake_modules/Usevcpkg.cmake index a61918235b4..016cfd169e4 100644 --- a/cpp/cmake_modules/Usevcpkg.cmake +++ b/cpp/cmake_modules/Usevcpkg.cmake @@ -17,8 +17,6 @@ message(STATUS "Using vcpkg to find dependencies") -set(VCPKG_VERBOSE ON CACHE BOOL "-AL- test Enable verbose output from vcpkg") - # ---------------------------------------------------------------------- # Define macros From b62e04ed6d88296217bd8ed05d67ee2fb0b927c2 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 16:50:39 -0800 Subject: [PATCH 06/16] Move location of `packages: write` --- .github/workflows/cpp_extra.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index e419a7a24c7..e4784315568 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -334,13 +334,13 @@ jobs: needs: check-labels name: ODBC runs-on: windows-2022 + permissions: + packages: write if: >- needs.check-labels.outputs.force == 'true' || contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra') || contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra: C++') timeout-minutes: 240 - permissions: - packages: write env: ARROW_BUILD_SHARED: ON ARROW_BUILD_STATIC: OFF From 5fdf4251df18a4f2c1b7c697f99fe91ef6e1b9aa Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 16:57:59 -0800 Subject: [PATCH 07/16] Attempt to add `ARROW_DEPENDENCY_USE_SHARED - off` --- .github/workflows/cpp_extra.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index e4784315568..f7f19c695c6 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -347,6 +347,7 @@ jobs: ARROW_BUILD_TESTS: ON ARROW_BUILD_TYPE: release ARROW_DEPENDENCY_SOURCE: VCPKG + ARROW_DEPENDENCY_USE_SHARED: OFF ARROW_FLIGHT_SQL_ODBC: ON ARROW_HOME: /usr CMAKE_GENERATOR: Ninja From a00fbc22f5d5bff5cefadc63d82cc95328658d35 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 17:04:05 -0800 Subject: [PATCH 08/16] Revert "Move location of `packages: write`" This reverts commit b62e04ed6d88296217bd8ed05d67ee2fb0b927c2. Revert "Attempt to add `ARROW_DEPENDENCY_USE_SHARED - off`" This reverts commit 5fdf4251df18a4f2c1b7c697f99fe91ef6e1b9aa. --- .github/workflows/cpp_extra.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index f7f19c695c6..e419a7a24c7 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -334,20 +334,19 @@ jobs: needs: check-labels name: ODBC runs-on: windows-2022 - permissions: - packages: write if: >- needs.check-labels.outputs.force == 'true' || contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra') || contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra: C++') timeout-minutes: 240 + permissions: + packages: write env: ARROW_BUILD_SHARED: ON ARROW_BUILD_STATIC: OFF ARROW_BUILD_TESTS: ON ARROW_BUILD_TYPE: release ARROW_DEPENDENCY_SOURCE: VCPKG - ARROW_DEPENDENCY_USE_SHARED: OFF ARROW_FLIGHT_SQL_ODBC: ON ARROW_HOME: /usr CMAKE_GENERATOR: Ninja From 099dba2c13e043d2f0db3694515cba1cd7a7f8f5 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 17:08:17 -0800 Subject: [PATCH 09/16] Add GLib MSVC build to C++ Extra --- .github/workflows/cpp_extra.yml | 145 ++++++++++++++++++++++++++++++++ 1 file changed, 145 insertions(+) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index e419a7a24c7..eb6e31123b2 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -446,6 +446,150 @@ jobs: # GH-47787 TODO: Build ODBC installer +# TODO remove below workflow +# -AL- check if moving GLib to C++ Extra workflow can still work. + test-glib: + needs: check-labels + name: TEST ONLY AMD64 Windows MSVC GLib + runs-on: windows-2022 + if: >- + needs.check-labels.outputs.force == 'true' || + contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra') || + contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra: C++') + timeout-minutes: 240 + strategy: + fail-fast: false + env: + ARROW_ACERO: ON + ARROW_BOOST_USE_SHARED: OFF + ARROW_BUILD_BENCHMARKS: OFF + ARROW_BUILD_SHARED: ON + ARROW_BUILD_STATIC: OFF + ARROW_BUILD_TESTS: OFF + ARROW_DATASET: ON + ARROW_DEPENDENCY_SOURCE: VCPKG + ARROW_DEPENDENCY_USE_SHARED: OFF + ARROW_FLIGHT: ON + ARROW_FLIGHT_SQL: ON + ARROW_GANDIVA: OFF + ARROW_GLIB_VAPI: "false" + ARROW_HDFS: OFF + ARROW_HOME: "${{ github.workspace }}/dist" + ARROW_JEMALLOC: OFF + ARROW_MIMALLOC: ON + ARROW_ORC: OFF + ARROW_PARQUET: ON + ARROW_SUBSTRAIT: OFF + ARROW_USE_GLOG: OFF + ARROW_VERBOSE_THIRDPARTY_BUILD: OFF + ARROW_WITH_BROTLI: OFF + ARROW_WITH_BZ2: OFF + ARROW_WITH_LZ4: OFF + ARROW_WITH_OPENTELEMETRY: OFF + ARROW_WITH_SNAPPY: ON + ARROW_WITH_ZLIB: ON + ARROW_WITH_ZSTD: ON + CMAKE_CXX_STANDARD: "20" + CMAKE_GENERATOR: Ninja + CMAKE_INSTALL_PREFIX: "${{ github.workspace }}/dist" + VCPKG_BINARY_SOURCES: 'clear;nuget,GitHub,readwrite' + VCPKG_DEFAULT_TRIPLET: x64-windows + permissions: + packages: write + steps: + - name: Disable Crash Dialogs + run: | + reg add ` + "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" ` + /v DontShowUI ` + /t REG_DWORD ` + /d 1 ` + /f + - name: Checkout Arrow + uses: actions/checkout@v6 + with: + fetch-depth: 0 + submodules: recursive + - name: Install meson + run: | + python -m pip install meson + - name: Install ccache + shell: bash + run: | + ci/scripts/install_ccache.sh 4.6.3 /usr + - name: Setup ccache + shell: bash + run: | + ci/scripts/ccache_setup.sh + - name: ccache info + id: ccache-info + shell: bash + run: | + echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT + - name: Cache ccache + uses: actions/cache@v5 + with: + path: ${{ steps.ccache-info.outputs.cache-dir }} + key: glib-ccache-msvc-${{ env.CACHE_VERSION }}-${{ hashFiles('cpp/**') }} + restore-keys: glib-ccache-msvc-${{ env.CACHE_VERSION }}- + env: + # We can invalidate the current cache by updating this. + CACHE_VERSION: "2024-05-09" + - name: Checkout vcpkg + uses: actions/checkout@v6 + with: + fetch-depth: 0 + path: vcpkg + repository: microsoft/vcpkg + - name: Bootstrap vcpkg + run: | + vcpkg\bootstrap-vcpkg.bat + $VCPKG_ROOT = $(Resolve-Path -LiteralPath "vcpkg").ToString() + Write-Output ${VCPKG_ROOT} | ` + Out-File -FilePath ${Env:GITHUB_PATH} -Encoding utf8 -Append + Write-Output "VCPKG_ROOT=${VCPKG_ROOT}" | ` + Out-File -FilePath ${Env:GITHUB_ENV} -Encoding utf8 -Append + - name: Setup NuGet credentials for vcpkg caching + shell: bash + run: | + $(vcpkg fetch nuget | tail -n 1) \ + sources add \ + -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \ + -storepasswordincleartext \ + -name "GitHub" \ + -username "$GITHUB_REPOSITORY_OWNER" \ + -password "${{ secrets.GITHUB_TOKEN }}" + $(vcpkg fetch nuget | tail -n 1) \ + setapikey "${{ secrets.GITHUB_TOKEN }}" \ + -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" + #-AL- for testing, remove later. + - name: Show vcpkg NuGet pwsh + shell: pwsh + run: | + vcpkg fetch nuget + - name: Show vcpkg NuGet bash + shell: bash + run: | + vcpkg fetch nuget + - name: Build C++ + shell: cmd + run: | + $env:VCPKG_DEBUG = "1" + set VCPKG_ROOT_KEEP=%VCPKG_ROOT% + call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 + set VCPKG_ROOT=%VCPKG_ROOT_KEEP% + # -AL- Below line returns 403 error also. + # But somehow the `cpp_build.sh` vcpkg build succeeds. + # vcpkg install abseil --debug + bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" + - name: Build GLib + shell: cmd + run: | + set VCPKG_ROOT_KEEP=%VCPKG_ROOT% + call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 + set VCPKG_ROOT=%VCPKG_ROOT_KEEP% + bash -c "ci/scripts/c_glib_build.sh $(pwd) $(pwd)/build" + report-extra-cpp: if: github.event_name == 'schedule' && always() needs: @@ -454,5 +598,6 @@ jobs: - jni-macos - msvc-arm64 - odbc + - test-glib uses: ./.github/workflows/report_ci.yml secrets: inherit From 4a488e85d01d31b930b33abc7bb96b6ae3485120 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Thu, 18 Dec 2025 17:08:30 -0800 Subject: [PATCH 10/16] TEMP disable ODBC build --- .github/workflows/cpp_extra.yml | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index eb6e31123b2..413c63abc80 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -428,18 +428,19 @@ jobs: shell: bash run: | vcpkg fetch nuget - - name: Build - shell: cmd - run: | - set VCPKG_ROOT_KEEP=%VCPKG_ROOT% - call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 - set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" + # -AL- TEMP disable. + # - name: Build + # shell: cmd + # run: | + # set VCPKG_ROOT_KEEP=%VCPKG_ROOT% + # call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 + # set VCPKG_ROOT=%VCPKG_ROOT_KEEP% + # bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - - name: Register Flight SQL ODBC Driver - shell: cmd - run: | - call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll + # - name: Register Flight SQL ODBC Driver + # shell: cmd + # run: | + # call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll # GH-48270 TODO: Resolve segementation fault during Arrow library unload # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI # GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved. From 0897b02db4750100f6a9a9ab1e36544f47993e03 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Fri, 19 Dec 2025 10:24:02 -0800 Subject: [PATCH 11/16] Disable cmake and enable build --- .github/workflows/cpp_extra.yml | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index 413c63abc80..6c2ccd9ef34 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -370,10 +370,11 @@ jobs: - name: Download Timezone Database shell: bash run: ci/scripts/download_tz_database.sh - - name: Install cmake - shell: bash - run: | - ci/scripts/install_cmake.sh 4.1.2 /usr + # Disable cmake for make it work with vcpkg. + # - name: Install cmake + # shell: bash + # run: | + # ci/scripts/install_cmake.sh 4.1.2 /usr - name: Install ccache shell: bash run: | @@ -429,18 +430,18 @@ jobs: run: | vcpkg fetch nuget # -AL- TEMP disable. - # - name: Build - # shell: cmd - # run: | - # set VCPKG_ROOT_KEEP=%VCPKG_ROOT% - # call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 - # set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - # bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" + - name: Build + shell: cmd + run: | + set VCPKG_ROOT_KEEP=%VCPKG_ROOT% + call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 + set VCPKG_ROOT=%VCPKG_ROOT_KEEP% + bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - # - name: Register Flight SQL ODBC Driver - # shell: cmd - # run: | - # call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll + - name: Register Flight SQL ODBC Driver + shell: cmd + run: | + call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll # GH-48270 TODO: Resolve segementation fault during Arrow library unload # GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI # GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved. From dfea3774de18f764ee6bcba8293d347e4e358813 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Fri, 19 Dec 2025 12:03:00 -0800 Subject: [PATCH 12/16] Re-enable cmake 4.1.2 and use install_vcpkg.sh to install vcpkg --- .github/workflows/cpp_extra.yml | 45 ++++++++++++--------------------- 1 file changed, 16 insertions(+), 29 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index 6c2ccd9ef34..bb99e78d76a 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -370,11 +370,6 @@ jobs: - name: Download Timezone Database shell: bash run: ci/scripts/download_tz_database.sh - # Disable cmake for make it work with vcpkg. - # - name: Install cmake - # shell: bash - # run: | - # ci/scripts/install_cmake.sh 4.1.2 /usr - name: Install ccache shell: bash run: | @@ -394,33 +389,25 @@ jobs: path: ${{ steps.ccache-info.outputs.cache-dir }} key: cpp-odbc-ccache-windows-x64-${{ hashFiles('cpp/**') }} restore-keys: cpp-odbc-ccache-windows-x64- - - name: Checkout vcpkg - uses: actions/checkout@v6 - with: - fetch-depth: 0 - path: vcpkg - repository: microsoft/vcpkg - - name: Bootstrap vcpkg + - name: Install cmake + shell: bash run: | - vcpkg\bootstrap-vcpkg.bat - $VCPKG_ROOT = $(Resolve-Path -LiteralPath "vcpkg").ToString() - Write-Output ${VCPKG_ROOT} | ` - Out-File -FilePath ${Env:GITHUB_PATH} -Encoding utf8 -Append - Write-Output "VCPKG_ROOT=${VCPKG_ROOT}" | ` - Out-File -FilePath ${Env:GITHUB_ENV} -Encoding utf8 -Append - - name: Setup NuGet credentials for vcpkg caching + ci/scripts/install_cmake.sh 4.1.2 /usr + - name: Retrieve VCPKG version from arrow/.env shell: bash run: | - $(vcpkg fetch nuget | tail -n 1) \ - sources add \ - -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \ - -storepasswordincleartext \ - -name "GitHub" \ - -username "$GITHUB_REPOSITORY_OWNER" \ - -password "${{ secrets.GITHUB_TOKEN }}" - $(vcpkg fetch nuget | tail -n 1) \ - setapikey "${{ secrets.GITHUB_TOKEN }}" \ - -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" + vcpkg_version=$(. ".env" && echo "${VCPKG}") + echo "VCPKG_VERSION=$vcpkg_version" >> $GITHUB_ENV + - name: Set Vcpkg PATH + shell: pwsh + run: | + echo "VCPKG_ROOT=${{ github.workspace }}\vcpkg" >> $env:GITHUB_ENV + - name: Install Vcpkg + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + shell: bash + run: | + ci/scripts/install_vcpkg.sh $VCPKG_ROOT $VCPKG_VERSION - name: Show vcpkg NuGet pwsh shell: pwsh run: | From bc62a23b76da3b5a6052d59475a32474493af9b6 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Fri, 19 Dec 2025 15:53:51 -0800 Subject: [PATCH 13/16] Clean up test changes Push after previous run is complete. --- .github/workflows/cpp_extra.yml | 146 -------------------------------- .github/workflows/ruby.yml | 12 --- 2 files changed, 158 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index bb99e78d76a..428ce87ec67 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -416,7 +416,6 @@ jobs: shell: bash run: | vcpkg fetch nuget - # -AL- TEMP disable. - name: Build shell: cmd run: | @@ -435,150 +434,6 @@ jobs: # GH-47787 TODO: Build ODBC installer -# TODO remove below workflow -# -AL- check if moving GLib to C++ Extra workflow can still work. - test-glib: - needs: check-labels - name: TEST ONLY AMD64 Windows MSVC GLib - runs-on: windows-2022 - if: >- - needs.check-labels.outputs.force == 'true' || - contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra') || - contains(fromJSON(needs.check-labels.outputs.ci-extra-labels || '[]'), 'CI: Extra: C++') - timeout-minutes: 240 - strategy: - fail-fast: false - env: - ARROW_ACERO: ON - ARROW_BOOST_USE_SHARED: OFF - ARROW_BUILD_BENCHMARKS: OFF - ARROW_BUILD_SHARED: ON - ARROW_BUILD_STATIC: OFF - ARROW_BUILD_TESTS: OFF - ARROW_DATASET: ON - ARROW_DEPENDENCY_SOURCE: VCPKG - ARROW_DEPENDENCY_USE_SHARED: OFF - ARROW_FLIGHT: ON - ARROW_FLIGHT_SQL: ON - ARROW_GANDIVA: OFF - ARROW_GLIB_VAPI: "false" - ARROW_HDFS: OFF - ARROW_HOME: "${{ github.workspace }}/dist" - ARROW_JEMALLOC: OFF - ARROW_MIMALLOC: ON - ARROW_ORC: OFF - ARROW_PARQUET: ON - ARROW_SUBSTRAIT: OFF - ARROW_USE_GLOG: OFF - ARROW_VERBOSE_THIRDPARTY_BUILD: OFF - ARROW_WITH_BROTLI: OFF - ARROW_WITH_BZ2: OFF - ARROW_WITH_LZ4: OFF - ARROW_WITH_OPENTELEMETRY: OFF - ARROW_WITH_SNAPPY: ON - ARROW_WITH_ZLIB: ON - ARROW_WITH_ZSTD: ON - CMAKE_CXX_STANDARD: "20" - CMAKE_GENERATOR: Ninja - CMAKE_INSTALL_PREFIX: "${{ github.workspace }}/dist" - VCPKG_BINARY_SOURCES: 'clear;nuget,GitHub,readwrite' - VCPKG_DEFAULT_TRIPLET: x64-windows - permissions: - packages: write - steps: - - name: Disable Crash Dialogs - run: | - reg add ` - "HKCU\SOFTWARE\Microsoft\Windows\Windows Error Reporting" ` - /v DontShowUI ` - /t REG_DWORD ` - /d 1 ` - /f - - name: Checkout Arrow - uses: actions/checkout@v6 - with: - fetch-depth: 0 - submodules: recursive - - name: Install meson - run: | - python -m pip install meson - - name: Install ccache - shell: bash - run: | - ci/scripts/install_ccache.sh 4.6.3 /usr - - name: Setup ccache - shell: bash - run: | - ci/scripts/ccache_setup.sh - - name: ccache info - id: ccache-info - shell: bash - run: | - echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT - - name: Cache ccache - uses: actions/cache@v5 - with: - path: ${{ steps.ccache-info.outputs.cache-dir }} - key: glib-ccache-msvc-${{ env.CACHE_VERSION }}-${{ hashFiles('cpp/**') }} - restore-keys: glib-ccache-msvc-${{ env.CACHE_VERSION }}- - env: - # We can invalidate the current cache by updating this. - CACHE_VERSION: "2024-05-09" - - name: Checkout vcpkg - uses: actions/checkout@v6 - with: - fetch-depth: 0 - path: vcpkg - repository: microsoft/vcpkg - - name: Bootstrap vcpkg - run: | - vcpkg\bootstrap-vcpkg.bat - $VCPKG_ROOT = $(Resolve-Path -LiteralPath "vcpkg").ToString() - Write-Output ${VCPKG_ROOT} | ` - Out-File -FilePath ${Env:GITHUB_PATH} -Encoding utf8 -Append - Write-Output "VCPKG_ROOT=${VCPKG_ROOT}" | ` - Out-File -FilePath ${Env:GITHUB_ENV} -Encoding utf8 -Append - - name: Setup NuGet credentials for vcpkg caching - shell: bash - run: | - $(vcpkg fetch nuget | tail -n 1) \ - sources add \ - -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \ - -storepasswordincleartext \ - -name "GitHub" \ - -username "$GITHUB_REPOSITORY_OWNER" \ - -password "${{ secrets.GITHUB_TOKEN }}" - $(vcpkg fetch nuget | tail -n 1) \ - setapikey "${{ secrets.GITHUB_TOKEN }}" \ - -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" - #-AL- for testing, remove later. - - name: Show vcpkg NuGet pwsh - shell: pwsh - run: | - vcpkg fetch nuget - - name: Show vcpkg NuGet bash - shell: bash - run: | - vcpkg fetch nuget - - name: Build C++ - shell: cmd - run: | - $env:VCPKG_DEBUG = "1" - set VCPKG_ROOT_KEEP=%VCPKG_ROOT% - call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 - set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - # -AL- Below line returns 403 error also. - # But somehow the `cpp_build.sh` vcpkg build succeeds. - # vcpkg install abseil --debug - bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - - name: Build GLib - shell: cmd - run: | - set VCPKG_ROOT_KEEP=%VCPKG_ROOT% - call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 - set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - bash -c "ci/scripts/c_glib_build.sh $(pwd) $(pwd)/build" - report-extra-cpp: if: github.event_name == 'schedule' && always() needs: @@ -587,6 +442,5 @@ jobs: - jni-macos - msvc-arm64 - odbc - - test-glib uses: ./.github/workflows/report_ci.yml secrets: inherit diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index b21637d49f1..49589045d3a 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -422,15 +422,6 @@ jobs: $(vcpkg fetch nuget | tail -n 1) \ setapikey "${{ secrets.GITHUB_TOKEN }}" \ -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" - #-AL- for testing, remove later. - - name: Show vcpkg NuGet pwsh - shell: pwsh - run: | - vcpkg fetch nuget - - name: Show vcpkg NuGet bash - shell: bash - run: | - vcpkg fetch nuget - name: Build C++ shell: cmd run: | @@ -438,9 +429,6 @@ jobs: set VCPKG_ROOT_KEEP=%VCPKG_ROOT% call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 set VCPKG_ROOT=%VCPKG_ROOT_KEEP% - # -AL- Below line returns 403 error also. - # But somehow the `cpp_build.sh` vcpkg build succeeds. - # vcpkg install abseil --debug bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - name: Build GLib shell: cmd From 0c911a5089bc76bbd63cdd78cb96c01933be547b Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Fri, 19 Dec 2025 16:07:32 -0800 Subject: [PATCH 14/16] Revert "Re-enable cmake 4.1.2 and use install_vcpkg.sh to install vcpkg" This reverts commit dfea3774de18f764ee6bcba8293d347e4e358813. --- .github/workflows/cpp_extra.yml | 49 ++++++++++++++++----------------- .github/workflows/ruby.yml | 1 - 2 files changed, 24 insertions(+), 26 deletions(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index 428ce87ec67..22820836a3f 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -389,33 +389,33 @@ jobs: path: ${{ steps.ccache-info.outputs.cache-dir }} key: cpp-odbc-ccache-windows-x64-${{ hashFiles('cpp/**') }} restore-keys: cpp-odbc-ccache-windows-x64- - - name: Install cmake - shell: bash - run: | - ci/scripts/install_cmake.sh 4.1.2 /usr - - name: Retrieve VCPKG version from arrow/.env - shell: bash - run: | - vcpkg_version=$(. ".env" && echo "${VCPKG}") - echo "VCPKG_VERSION=$vcpkg_version" >> $GITHUB_ENV - - name: Set Vcpkg PATH - shell: pwsh - run: | - echo "VCPKG_ROOT=${{ github.workspace }}\vcpkg" >> $env:GITHUB_ENV - - name: Install Vcpkg - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - shell: bash - run: | - ci/scripts/install_vcpkg.sh $VCPKG_ROOT $VCPKG_VERSION - - name: Show vcpkg NuGet pwsh - shell: pwsh + - name: Checkout vcpkg + uses: actions/checkout@v6 + with: + fetch-depth: 0 + path: vcpkg + repository: microsoft/vcpkg + - name: Bootstrap vcpkg run: | - vcpkg fetch nuget - - name: Show vcpkg NuGet bash + vcpkg\bootstrap-vcpkg.bat + $VCPKG_ROOT = $(Resolve-Path -LiteralPath "vcpkg").ToString() + Write-Output ${VCPKG_ROOT} | ` + Out-File -FilePath ${Env:GITHUB_PATH} -Encoding utf8 -Append + Write-Output "VCPKG_ROOT=${VCPKG_ROOT}" | ` + Out-File -FilePath ${Env:GITHUB_ENV} -Encoding utf8 -Append + - name: Setup NuGet credentials for vcpkg caching shell: bash run: | - vcpkg fetch nuget + $(vcpkg fetch nuget | tail -n 1) \ + sources add \ + -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" \ + -storepasswordincleartext \ + -name "GitHub" \ + -username "$GITHUB_REPOSITORY_OWNER" \ + -password "${{ secrets.GITHUB_TOKEN }}" + $(vcpkg fetch nuget | tail -n 1) \ + setapikey "${{ secrets.GITHUB_TOKEN }}" \ + -source "https://nuget.pkg.github.com/$GITHUB_REPOSITORY_OWNER/index.json" - name: Build shell: cmd run: | @@ -423,7 +423,6 @@ jobs: call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 set VCPKG_ROOT=%VCPKG_ROOT_KEEP% bash -c "ci/scripts/cpp_build.sh $(pwd) $(pwd)/build" - - name: Register Flight SQL ODBC Driver shell: cmd run: | diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 49589045d3a..3545f1c16a5 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -425,7 +425,6 @@ jobs: - name: Build C++ shell: cmd run: | - $env:VCPKG_DEBUG = "1" set VCPKG_ROOT_KEEP=%VCPKG_ROOT% call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64 set VCPKG_ROOT=%VCPKG_ROOT_KEEP% From 837eedec8f41b130045b204f5230654ad7c3acbe Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Fri, 19 Dec 2025 17:19:22 -0800 Subject: [PATCH 15/16] Trigger CI From 8260a0cc4470a79ee94d9a05ffc5372c2af2ebf5 Mon Sep 17 00:00:00 2001 From: "Alina (Xi) Li" Date: Tue, 23 Dec 2025 11:59:41 -0800 Subject: [PATCH 16/16] Apply Kou's suggestion for nuget timeout --- .github/workflows/cpp_extra.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cpp_extra.yml b/.github/workflows/cpp_extra.yml index 22820836a3f..15c022a5622 100644 --- a/.github/workflows/cpp_extra.yml +++ b/.github/workflows/cpp_extra.yml @@ -351,7 +351,7 @@ jobs: ARROW_HOME: /usr CMAKE_GENERATOR: Ninja CMAKE_INSTALL_PREFIX: /usr - VCPKG_BINARY_SOURCES: 'clear;nuget,GitHub,readwrite' + VCPKG_BINARY_SOURCES: 'clear;nugettimeout,600;nuget,GitHub,readwrite' VCPKG_DEFAULT_TRIPLET: x64-windows steps: - name: Disable Crash Dialogs