-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Description
What happened?
Running TypeScript SDK tests fails on a fresh clone after npm install:
cd sdks/typescript
npm install
npm test
Error:
Cannot find module '@gradle-tech/develocity-agent/mocha-reporter'
Require stack: sdks/typescript/reporterConfig.js -> cypress-multi-reporters -> mocha ...
Why
sdks/typescript/.mocharc.json configures Mocha to always load reporterConfig.js, and reporterConfig.js hard-requires
@gradle-tech/develocity-agent/mocha-reporter, but @gradle-tech/develocity-agent is not listed in sdks/typescript/package.json devDependencies.
Expected behavior
npm test should run out-of-the-box after npm install (even if the Develocity reporter is not installed).
Proposed fix
Make the reporter optional (fallback to "spec" when the module cannot be resolved), or alternatively add the missing dependency to devDependencies.
Environment
- OS: macOS (Apple Silicon)
- Node: v20.19.4
- npm: 11.6.4
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components
- Component: Python SDK
- Component: Java SDK
- Component: Go SDK
- Component: Typescript SDK
- Component: IO connector
- Component: Beam YAML
- Component: Beam examples
- Component: Beam playground
- Component: Beam katas
- Component: Website
- Component: Infrastructure
- Component: Spark Runner
- Component: Flink Runner
- Component: Samza Runner
- Component: Twister2 Runner
- Component: Hazelcast Jet Runner
- Component: Google Cloud Dataflow Runner