Update

Author: tuhaihe

.asf.yaml

@@ -53,6 +53,7 @@ github:
         # contexts are the names of checks that must pass.
         contexts:
           - build_and_unit_test
+          - code_quality
       required_pull_request_reviews:
         dismiss_stale_reviews: false
         required_approving_review_count: 1

.github/workflows/build_and_unit_test.yml

@@ -1,4 +1,4 @@
-name: build_and_unit_test
+name: Build and Unit Test
 
 on:
   push:
@@ -22,50 +22,8 @@ env:
   GOBIN: ${{ github.workspace }}/.go/bin
 
 jobs:
-  # Code quality checks
-  code_quality:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v4
-      with:
-        fetch-depth: 0
-
-    - name: Set up Go
-      uses: actions/setup-go@v5
-      with:
-        go-version: ${{ env.GO_VERSION }}
-        cache: true
-
-    - name: Setup GOPATH/PATH
-      run: |
-        echo "GOPATH=${GOPATH}" >> "$GITHUB_ENV"
-        echo "${GOBIN}" >> "$GITHUB_PATH"
-
-    - name: Install dependencies
-      run: make depend
-
-    - name: Formatting check (read-only)
-      run: |
-        go install golang.org/x/tools/cmd/goimports@latest
-        CHANGED=$(goimports -l $(git ls-files '*.go'))
-        if [ -n "$CHANGED" ]; then
-          echo "The following files need formatting:"
-          echo "$CHANGED"
-          echo "Please run: make format"
-          exit 1
-        fi
-
-    - name: GolangCI-Lint
-      uses: golangci/golangci-lint-action@v4
-      with:
-        version: v1.56.2
-        args: --tests=false
-        only-new-issues: true
 
-  # Build and unit tests with GPDB version matrix
   build_and_unit_test:
-    needs: code_quality
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/code_quality.yml

@@ -0,0 +1,74 @@
+name: Code Quality Check
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+    types: [ opened, synchronize, reopened, edited, ready_for_review ]
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+env:
+  GO_VERSION: '1.21'
+  GOPATH: ${{ github.workspace }}/.go
+  GOBIN: ${{ github.workspace }}/.go/bin
+
+jobs:
+  code_quality:
+    runs-on: ubuntu-latest
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+      with:
+        fetch-depth: 0
+
+    - name: Set up Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: ${{ env.GO_VERSION }}
+        cache: true
+
+    - name: Setup GOPATH/PATH
+      run: |
+        echo "GOPATH=${GOPATH}" >> "$GITHUB_ENV"
+        echo "${GOBIN}" >> "$GITHUB_PATH"
+
+    - name: Install dependencies
+      run: make depend
+
+    - name: Formatting check (read-only)
+      run: |
+        set -eo pipefail
+        command -v goimports >/dev/null || go install golang.org/x/tools/cmd/goimports@latest
+        files=$(git ls-files '*.go')
+        if [ -z "$files" ]; then
+          echo "No Go files found. Skipping formatting check."
+          exit 0
+        fi
+        CHANGED=$(goimports -l $files)
+        if [ -n "$CHANGED" ]; then
+          echo "$CHANGED"
+          echo "### Formatting issues" >> "$GITHUB_STEP_SUMMARY"
+          echo "$CHANGED" | sed 's/^/- /' >> "$GITHUB_STEP_SUMMARY"
+          echo "Please run \`make format\` on your local machine" >> "$GITHUB_STEP_SUMMARY"
+          exit 1
+        fi
+
+    - name: GolangCI-Lint (no PR annotations)
+      run: |
+        set -eo pipefail
+        command -v golangci-lint >/dev/null || go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.56.2
+        OUTPUT=$(golangci-lint run --tests=false --out-format=colored-line-number || true)
+        if [ -n "$OUTPUT" ]; then
+          echo "$OUTPUT"
+          echo "### GolangCI-Lint issues" >> "$GITHUB_STEP_SUMMARY"
+          echo "$OUTPUT" | sed 's/^/- /' >> "$GITHUB_STEP_SUMMARY"
+          exit 1
+        fi