-
Notifications
You must be signed in to change notification settings - Fork 707
Open
Labels
good first issueGood for newcomersGood for newcomersimprovementImprovements on everythingImprovements on everything
Description
What would you like to be improved?
Prevent the SetModelVersionProperty CLI command from accepting both an alias and version (or neither), ensuring it fails instead of invoking the server with invalid inputs. Include unit tests, for example:
@Test
void validateBothAliasAndVersion() {
CommandLine mockCmdLine = Mockito.mock(CommandLine.class);
CommandContext context = new CommandContext(mockCmdLine);
SetModelVersionProperty command =
new SetModelVersionProperty(
context,
"metalake1",
"catalog1",
"schema1",
"model1",
1,
"alias1",
"prop",
"value");
Assertions.assertThrows(RuntimeException.class, command::validate);
}
How should we improve?
Improve validation and add unit tests, note you'll need to do this Main.useExit = false;.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomersimprovementImprovements on everythingImprovements on everything