IGNITE-26296 Generate SystemViewRowAttributeWalker at compile time #12672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

NSAmelchev wants to merge 23 commits into apache:master from NSAmelchev:ignite-26296

.github/workflows/commit-check.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,7 @@ jobs: @@
           - name: Check javadocs.
             run : |
-              ./mvnw -DskipTests install -pl modules/tools,modules/codegen2 -B -V && ./mvnw initialize -Pjavadoc -B -V
+              ./mvnw -DskipTests install -pl modules/tools,modules/codegen -B -V && ./mvnw initialize -Pjavadoc -B -V
       check-dotnet:
         name: Сheck .NET code
@@ Expand Down @@

assembly/dependencies-apache-ignite.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -129,7 +129,6 @@ @@
                     <exclude>${project.groupId}:ignite-examples</exclude>
                     <exclude>${project.groupId}:ignite-indexing</exclude>
                     <exclude>${project.groupId}:ignite-codegen</exclude>
-                    <exclude>${project.groupId}:ignite-codegen2</exclude>
                     <exclude>${project.groupId}:ignite-schedule</exclude>
                     <exclude>${project.groupId}:ignite-appserver-test</exclude>
                     <exclude>${project.groupId}:ignite-websphere-test</exclude>
@@ Expand Down @@

modules/bom/pom.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -183,7 +183,7 @@ @@
                 </dependency>
                 <dependency>
                     <groupId>${project.groupId}</groupId>
-                    <artifactId>ignite-codegen2</artifactId>
+                    <artifactId>ignite-codegen</artifactId>
                     <version>${revision}</version>
                 </dependency>
                 <dependency>
@@ Expand Down @@

modules/calcite/pom.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -74,7 +74,7 @@ @@
             <dependency>
                 <groupId>${project.groupId}</groupId>
-                <artifactId>ignite-codegen2</artifactId>
+                <artifactId>ignite-codegen</artifactId>
                 <scope>provided</scope>
             </dependency>
@@ Expand Down @@

modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinMetadataSelfTest.java

-Original file line number
+Diff line change
@@ Expand Up / @@ -812,6 +812,7 @@ public void testGetAllColumns() throws Exception { @@
                     "SYS.NODES.NODE_ORDER.null",
                     "SYS.NODES.ADDRESSES.null",
                     "SYS.NODES.HOSTNAMES.null",
+                    "SYS.NODES.DATA_CENTER_ID.null",
                     "SYS.NODE_ATTRIBUTES.NODE_ID.null",
                     "SYS.NODE_ATTRIBUTES.NAME.null",
                     "SYS.NODE_ATTRIBUTES.VALUE.null",
@@ Expand Down @@

modules/codegen2/README.md → modules/codegen/README.md

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -1,8 +1,12 @@
  
    # Message Processor Module

    # Code generation module

    This Maven module provides an annotation processor that automatically generates efficient serializer classes for all types implementing the `Message` interface. It is designed to run during the Java compilation phase and integrates seamlessly into build process.

    This Maven module provides annotation processors that automatically generate code, such as serializers, walkers, etc. It is designed to run during the Java compilation phase and integrates seamlessly into the build process.

    ## Purpose

    ## Message Processor

    This annotation processor automatically generates efficient serializer classes for all types implementing the `Message` interface. 

    ### Purpose

    The `MessageProcessor` performs the following tasks:

    @@ -13,7 +17,7 @@ The `MessageProcessor` performs the following tasks:
  
        - A setter named after the field, accepting a single argument (e.g., `fieldName(Type val)`)

    -  **Access Modifiers**: Getters and setters for all fields annotated with `@Order` must be declared as `public`

    ## Usage

    ### Usage

    1. **Prepare your Message class**

    @@ -38,10 +42,3 @@ At compile time, a class `MyMessageSerializer` implemented `MessageSerializer` w
  
    3. **Validation**

    If the `@Order` values are not sequential starting from 0, or if getter/setter method names do not match the field name, compilation will fail with a meaningful error message pointing to the problematic element.

    ## **Maven codegen modules**

    To avoid a circular dependency between `ignite-core` (which contains message classes) and `ignite-codegen` (which needs to know about them), the annotation processor is **temporarily placed in a separate module**. This separation allows the processor to remain independent of core classes during compilation.

    In the future, this structure may be consolidated when build system constraints are resolved.

modules/codegen/pom.xml

-Original file line number
+Diff line change
@@ Expand Up / @@ -38,17 +38,7 @@ @@
         <dependencies>
             <dependency>
                 <groupId>${project.groupId}</groupId>
-                <artifactId>ignite-core</artifactId>
-            </dependency>
-            <dependency>
-                <groupId>${project.groupId}</groupId>
-                <artifactId>ignite-indexing</artifactId>
-            </dependency>
-            <dependency>
-                <groupId>org.apache.ignite</groupId>
-                <artifactId>ignite-calcite</artifactId>
+                <artifactId>ignite-commons</artifactId>
             </dependency>
         </dependencies>
@@ Expand All / @@ -61,6 +51,24 @@ @@
                         <skip>true</skip>
                     </configuration>
                 </plugin>
+                <!--
+                    Disables annotation processing (MessageProcessor) during compilation of the module itself.
+                    If annotation processing is not explicitly disabled (-proc:none), the compiler may try to execute
+                    the processor during its own compilation, which lead to a compilation error.
+                -->
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-compiler-plugin</artifactId>
+                    <executions>
+                        <execution>
+                            <id>default-compile</id>
+                            <configuration>
+                                <compilerArgument>-proc:none</compilerArgument>
+                            </configuration>
+                        </execution>
+                    </executions>
+                </plugin>
             </plugins>
         </build>
     </project>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IGNITE-26296 Generate SystemViewRowAttributeWalker at compile time #12672

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

IGNITE-26296 Generate SystemViewRowAttributeWalker at compile time #12672

Are you sure you want to change the base?

Uh oh!

IGNITE-26296 Generate SystemViewRowAttributeWalker at compile time #12672

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!