[MWAR-446] Add an option to put libs in STORED mode (instead of DEFLATED)

[jira-importer]

Gaël Lalire opened MWAR-446 and commented

---

Issue Links:

• MEAR-306 Add an option to put libs in STORED mode (instead of DEFLATED)

[jira-importer]

Michael Osipov commented

What about https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html#recompressZippedFiles?

[jira-importer]

Michael Osipov commented

I expect this to work: https://codehaus-plexus.github.io/plexus-archiver/xref/org/codehaus/plexus/archiver/zip/ConcurrentJarCreator.html#L264

[jira-importer]

Gaël Lalire commented

recompressZippedFiles does not seems to do anything (at least for Maven dependencies, I don't know if you put a zip in src/main/resources).

Tested with 3.3.2 at https://github.com/vestige-java-app/mywar/tree/testRecompressOption with false and true value, the dependencies are always deflated.

[jira-importer]

Michael Osipov commented

Thanks, I reproducer is always good. I will take a look.

[jira-importer]

Michael Osipov commented

I did a bit of analysis. The issue is not in Plexus Archiver because there is a test which guarantees that ZIP types aren't recompressed:

$ zipinfo dont-recompress-added-zips.zip
Archive:  dont-recompress-added-zips.zip
Zip file size: 3368 bytes, number of entries: 5
-rw-r--r--  2.0 unx      383 b- defN 21-Dec-19 15:02 test.tar.gz
-rw-r--r--  2.0 unx      157 b- stor 21-Dec-19 15:02 test.zip
-rw-r--r--  2.0 unx      167 b- stor 21-Dec-19 15:02 namelessrootfolder.jar
-rw-r--r--  2.0 unx     1070 b- stor 21-Dec-19 15:02 test.jar
-rwxr-xr-x  2.0 unx     1070 b- stor 21-Dec-19 15:02 test.rar
5 files, 2847 bytes uncompressed, 2852 bytes compressed:  -0.2%

So the bug must be either in MWAR or MARCHIVER.

[jira-importer]

Michael Osipov commented

Just debugged, the ConcurrentJarCreator is never used here. I assume that this class is only used for JARs...