Skip to content

[PSA-303482] Feature/h12/change implementation of getting averages #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pwrightcertinia merged 6 commits into from
Nov 18, 2025
Merged

[PSA-303482] Feature/h12/change implementation of getting averages #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
34657c0
Update UI test alert to use 15 day average
amillercertinia Nov 18, 2025
57c0f0d
Ignore tests with less than 15 days results when generating alerts
amillercertinia Nov 18, 2025
628344f
Fix UI test alert logic
amillercertinia Nov 18, 2025
8a8cbbd
Merge pull request #2 from amillercertinia/feature/h12/PSA-303482-cha…
amillercertinia Nov 18, 2025
59a8bdc
Bump version number
amillercertinia Nov 18, 2025
6bbcadc
Temporarily remove postversion script
amillercertinia Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Benchmarker - Changelog

## 6.0.1

- Update logic for UI test alerts to use 15 days worth of results for averages.
- Update logic for UI test alerts so that tests with less than 15 days worth of results will not alert.

## 6.0.0

### Breaking Changes
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@apexdevtools/benchmarker",
"version": "6.0.0",
"version": "6.0.1",
"description": "Benchmarks performance of processes on Salesforce Orgs",
"author": {
"name": "Apex Dev Tools Team",
Expand All @@ -25,7 +25,6 @@
"doc:generate": "typedoc --out docs/api ./src",
"lint": "eslint ./src ./test ./test_system --fix",
"prepare": "ts-patch install -s && husky",
"postversion": "npm run doc:generate",
"test": "nyc mocha --timeout 10000 'test/**/*.test.*'",
"test:only": "nyc mocha --timeout 10000",
"test:system:init": "cp test_system/.env .env",
Expand Down
99 changes: 68 additions & 31 deletions src/database/uiAlertInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,57 +30,94 @@ export async function getAverageLimitValuesFromDB(
) {
const connection = await getConnection();

const countQuery = `
SELECT individual_test_name,
COUNT(create_date_time) AS count_older_than_15_days
FROM performance.ui_test_result
WHERE create_date_time <= CURRENT_DATE - INTERVAL '15 days'
GROUP BY individual_test_name
`;

const countResultMap: {
[key: string]: { count_older_than_15_days: number };
} = {};
try {
const countResult = await connection.query(countQuery);
countResult.forEach(
(row: {
individual_test_name: string;
count_older_than_15_days: number;
}) => {
countResultMap[row.individual_test_name] = {
count_older_than_15_days: row.count_older_than_15_days,
};
}
);
} catch (error) {
console.error('Error in fetching the count values: ', error);
return {};
}

const suiteAndTestNameConditions = suiteAndTestNamePairs
.map(pair => `('${pair.testSuiteName}', '${pair.individualTestName}')`)
.flatMap(pair => {
if (
countResultMap[pair.individualTestName]?.count_older_than_15_days > 0
) {
return [`('${pair.testSuiteName}', '${pair.individualTestName}')`];
}
return [];
})
.join(', ');

const query = `
WITH ranked AS (
SELECT
test_suite_name,
individual_test_name,
component_load_time,
create_date_time,
ROW_NUMBER() OVER (
PARTITION BY test_suite_name, individual_test_name
ORDER BY create_date_time DESC
) AS rn
FROM performance.ui_test_result
WHERE (create_date_time >= CURRENT_TIMESTAMP - INTERVAL '30 DAYS')
AND (test_suite_name, individual_test_name) IN (${suiteAndTestNameConditions})
)
SELECT
test_suite_name,
individual_test_name,
ROUND(AVG(CASE WHEN rn BETWEEN 1 AND 5 THEN component_load_time END)::numeric, 0) AS avg_first_5,
ROUND(AVG(CASE WHEN rn BETWEEN 6 AND 15 THEN component_load_time END)::numeric, 0) AS avg_next_10
FROM ranked
GROUP BY test_suite_name, individual_test_name
HAVING COUNT(*) >= 15
if (suiteAndTestNameConditions.length === 0) {
return {};
}

const avgQuery = `
SELECT
individual_test_name,
test_suite_name,
AVG(CASE
WHEN create_date_time >= CURRENT_DATE - INTERVAL '5 days'
THEN component_load_time
ELSE NULL
END) AS avg_load_time_past_5_days,
AVG(CASE
WHEN create_date_time >= CURRENT_DATE - INTERVAL '15 days'
AND create_date_time < CURRENT_DATE - INTERVAL '5 days'
THEN component_load_time
ELSE NULL
END) AS avg_load_time_6_to_15_days_ago
FROM performance.ui_test_result
WHERE create_date_time >= CURRENT_DATE - INTERVAL '15 days'
AND (test_suite_name, individual_test_name) IN (${suiteAndTestNameConditions})
GROUP BY individual_test_name, test_suite_name
ORDER BY individual_test_name;
`;

const resultsMap: {
[key: string]: {
avg_first_5: number;
avg_next_10: number;
avg_load_time_past_5_days: number;
avg_load_time_6_to_15_days_ago: number;
};
} = {};

try {
const result = await connection.query(query);
const result = await connection.query(avgQuery);

// Populate the results map
result.forEach(
(row: {
test_suite_name: string;
individual_test_name: string;
avg_first_5: number;
avg_next_10: number;
avg_load_time_past_5_days: number;
avg_load_time_6_to_15_days_ago: number;
}) => {
const key = `${row.test_suite_name}_${row.individual_test_name}`;
resultsMap[key] = {
avg_first_5: row.avg_first_5 ?? 0,
avg_next_10: row.avg_next_10 ?? 0,
avg_load_time_past_5_days: row.avg_load_time_past_5_days ?? 0,
avg_load_time_6_to_15_days_ago:
row.avg_load_time_6_to_15_days_ago ?? 0,
};
}
);
Expand Down
7 changes: 4 additions & 3 deletions src/services/result/uiAlert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ async function addAlertByComparingAvg(
output: UiTestResultDTO,
preFetchedAverages: {
[key: string]: {
avg_first_5: number;
avg_next_10: number;
avg_load_time_past_5_days: number;
avg_load_time_6_to_15_days_ago: number;
};
}
): Promise<UiAlert> {
Expand All @@ -85,7 +85,8 @@ async function addAlertByComparingAvg(
? output.alertInfo.uiAlertThresholds.componentLoadTimeThresholdCritical
: Number(getCriticalComponentLoadThreshold());
const componentLoadThresholdDegraded = Math.abs(
averageResults.avg_first_5 - averageResults.avg_next_10
averageResults.avg_load_time_past_5_days -
averageResults.avg_load_time_6_to_15_days_ago
);

if (
Expand Down
Loading