From e7c2299bcde3314eb5f6ed770651c6a91d107bf9 Mon Sep 17 00:00:00 2001 From: Xing Wei Date: Tue, 1 Nov 2016 17:24:15 -0700 Subject: [PATCH 1/2] xw - increase wait_until time when loading a page --- lib/ae_page_objects/document_loader.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ae_page_objects/document_loader.rb b/lib/ae_page_objects/document_loader.rb index 9c4ed4dc..cae07576 100644 --- a/lib/ae_page_objects/document_loader.rb +++ b/lib/ae_page_objects/document_loader.rb @@ -7,7 +7,7 @@ def initialize(query, strategy) def load begin - AePageObjects.wait_until do + AePageObjects.wait_until(10) do @query.conditions.each do |document_condition| if document = @strategy.load_document_with_condition(document_condition) return document From 7712e101466aa9e87c7b0f7e89343f77f102982b Mon Sep 17 00:00:00 2001 From: Xing Wei Date: Wed, 2 Nov 2016 10:27:54 -0700 Subject: [PATCH 2/2] xw - fix broken tests --- test/unit/document_loader_test.rb | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/unit/document_loader_test.rb b/test/unit/document_loader_test.rb index dc20a4c9..983e342e 100644 --- a/test/unit/document_loader_test.rb +++ b/test/unit/document_loader_test.rb @@ -54,11 +54,11 @@ def test_load_page__document_not_loaded_error loader = DocumentLoader.new(query, strategy) sequence = sequence('sequence') - strategy.expects(:load_document_with_condition).in_sequence(sequence).with(query.conditions[0]).returns(nil) - strategy.expects(:load_document_with_condition).in_sequence(sequence).with(query.conditions[1]).returns(nil) - strategy.expects(:load_document_with_condition).in_sequence(sequence).with(query.conditions[2]).returns(nil) + strategy.stubs(:load_document_with_condition).in_sequence(sequence).with(query.conditions[0]).returns(nil) + strategy.stubs(:load_document_with_condition).in_sequence(sequence).with(query.conditions[1]).returns(nil) + strategy.stubs(:load_document_with_condition).in_sequence(sequence).with(query.conditions[2]).returns(nil) - strategy.expects(:document_not_loaded_error_message).with(query).returns("hello") + strategy.stubs(:document_not_loaded_error_message).with(query).returns("hello") raised = assert_raise DocumentLoadError do loader.load @@ -113,5 +113,3 @@ def default_max_wait_time end end end - -