Skip to content

Commit 8a84231

Browse files
committed
Fix more tests
1 parent 2ef8100 commit 8a84231

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

axlearn/cloud/gcp/job_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def test_delete(self):
111111
patch_delete = mock.patch(f"{job.__name__}.delete_k8s_jobset")
112112
with patch_delete as mock_delete:
113113
cfg, _ = self._job_config(command="test-command", bundler_cls=CloudBuildBundler)
114-
gke_job = cfg.instantiate(bundler=mock.Mock())
114+
gke_job = cfg.instantiate(bundler=mock.create_autospec(Bundler))
115115
gke_job._delete() # pylint: disable=protected-access
116116
mock_delete.assert_called()
117117

@@ -295,6 +295,6 @@ def test_delete(self):
295295
patch_delete = mock.patch(f"{job.__name__}.delete_k8s_leaderworkerset")
296296
with patch_delete as mock_delete:
297297
cfg, _ = self._job_config(command="test-command", bundler_cls=CloudBuildBundler)
298-
gke_job = cfg.instantiate(bundler=mock.Mock())
298+
gke_job = cfg.instantiate(bundler=mock.create_autospec(Bundler))
299299
gke_job._delete() # pylint: disable=protected-access
300300
mock_delete.assert_called()

axlearn/cloud/gcp/jobset_utils_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def test_validate_jobset_name(self):
114114
self._job_config(bundler_cls=ArtifactRegistryBundler) as (cfg, _),
115115
):
116116
cfg.set(name="invalid_underscore_name", command="", output_dir="")
117-
cfg.instantiate(bundler=mock.Mock())
117+
cfg.instantiate(bundler=mock.create_autospec(Bundler))
118118

119119
@parameterized.product(
120120
[
@@ -603,7 +603,7 @@ def __call__(self):
603603
self.assertEqual(cfg.inner[child].name, child)
604604
self.assertEqual(cfg.inner[child].command, f"{child}_command")
605605

606-
composite = cfg.instantiate(bundler=mock.Mock())
606+
composite = cfg.instantiate(bundler=mock.create_autospec(Bundler))
607607
self.assertNestedEqual(
608608
[{"name": "a", "command": "a_command"}, {"name": "b", "command": "b_command"}],
609609
composite(),

0 commit comments

Comments
 (0)