Edit PKGBUILD: "yes" is the default answer when installing from AUR

[f2404]

Does it make sense? I mean, how often would you edit a PKGBUILD?
I'd suggest to make "no" the default one.

[f2404]

Since there's a thumb up already, I've submitted a PR.

[ArchangeGabriel]

Well, that’s a bad thing not to edit AUR PKGBUILD before building/installing (unless it’s an update and you make use of AURSHOWDIFF), so I would rather not encourage this behavior with this change.

[f2404]

@ArchangeGabriel Are you really editing PKGBUILD each time you install anything?

[ArchangeGabriel]

Like I said, unless it’s an update of something I have already installed (because I use AURSHOWDIFF mode), yes. And I even often make changes. Whatever, you’re supposed to do the same per ArchWiki.

Eventually, I would agree to have No as the default answer for upgrades, if possible relying on AURSHOWDIFF to be 1, but not mandatorily.

[rmarquis]

You guys are crazy.

[f2404]

@rmarquis What do you mean?

[rmarquis]

You're basically making yaourt even worst than it currently is. You should at least keep sane default. The config option for bypassing the PKGBUILDs checks is already available afaik.

[f2404]

There's EDITFILES option: when set to 0, it suppresses any prompts to edit pkgbuild or install files.
I'm ok with being prompted to edit them (and I would edit them sometimes); I just want the default option to be "no" so I would be able to install a package by just pressing Enter.
Another option would work for me, I guess.

[puckel]

A lot of people use --noconfirm to avoid to be prompted to pass "n"

[f2404]

Again, automation (including --noconfirm) leaves me no possibility to override program's default behavior - and I don't like not having a possibility. I want to make conscious decisions of editing or not editing certain files.

[larchunix]

IMHO, arguments from both sides make sense so I will let @Skunnyk decide if #297 should be merged or not.

[rmarquis]

Or simply keep that default and implement an option to reverse it...

[Skunnyk]

Hello,
For me, keeping "yes" is fine. For every AUR package installation you should check the pkgbuild.