From 7db54618246185da0d3ac8a051e7d7f0f778bd1a Mon Sep 17 00:00:00 2001 From: elidaniels Date: Mon, 7 Apr 2025 12:19:59 +0200 Subject: [PATCH 1/3] fix: Windows error 1224 --- R/readers.R | 2 +- R/workspace.R | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/R/readers.R b/R/readers.R index ccc8a32..e3cd531 100644 --- a/R/readers.R +++ b/R/readers.R @@ -45,7 +45,7 @@ read_dataset_in_workspace <- function(x, name) { cli_abort("Value of {.code name} is not unique in workspace.") } file <- file.path(x$dir, objs$file) - read_parquet(file) + read_parquet(file, mmap = FALSE) } #' @export diff --git a/R/workspace.R b/R/workspace.R index a54c8b6..b2ad5f8 100644 --- a/R/workspace.R +++ b/R/workspace.R @@ -26,7 +26,7 @@ read_objects_description <- function(x) { x$dir, paste0(.datasets_description, ".parquet") ) - read_parquet(file_objects_description) + read_parquet(file_objects_description, mmap = FALSE) } create_datasets_folder <- function(x) { @@ -200,7 +200,7 @@ unpack_workspace <- function(file) { dir, paste0(.datasets_description, ".parquet") ) - objects_desc <- read_parquet(file_datasets_description) + objects_desc <- read_parquet(file_datasets_description, mmap = FALSE) unlink(file_datasets_description, force = TRUE) x <- as_workspace_structure( dir = dir, From 7c2b5d10fbb7edeff21e62e6b0a850de4462ed4b Mon Sep 17 00:00:00 2001 From: elidaniels Date: Mon, 7 Apr 2025 12:20:31 +0200 Subject: [PATCH 2/3] up version --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 83cc2fb..0db63d5 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: workspace Title: Workspace and Data Management Tools -Version: 0.1.1 +Version: 0.1.1.0001 Authors@R: c( person("David", "Gohel", , "david.gohel@ardata.fr", role = c("aut", "cre")), person("ArData", role = "cph") From 4441bcd916222f682040bee29dfafedea3a60e36 Mon Sep 17 00:00:00 2001 From: elidaniels Date: Mon, 7 Apr 2025 14:20:32 +0200 Subject: [PATCH 3/3] Add windows to R CMD check action --- .github/workflows/R-CMD-check.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml index 678651b..280af40 100644 --- a/.github/workflows/R-CMD-check.yaml +++ b/.github/workflows/R-CMD-check.yaml @@ -20,6 +20,7 @@ jobs: config: - {os: macOS-latest, r: 'release'} - {os: ubuntu-20.04, r: 'release'} + - {os: windows-latest, r: 'release'} env: R_REMOTES_NO_ERRORS_FROM_WARNINGS: true