Move .local/share/arduino-app-cli in /var/lib

Author: martacarbone

Taskfile.yml

@@ -118,7 +118,7 @@ tasks:
           set -e
           echo "Runner version set as: {{ .EXAMPLE_VERSION }}"
           TMP_PATH="$(mktemp -d)"
-          DEST_PATH="debian/arduino-app-cli/home/arduino/.local/share/arduino-app-cli/"
+          DEST_PATH="debian/arduino-app-cli/var/lib/arduino-app-cli/"
           echo "Cloning arduino/app-bricks-examples into temporary directory ${TMP_PATH}..."
           git clone --depth 1 --branch "{{ .EXAMPLE_VERSION }}" https://github.com/arduino/app-bricks-examples "${TMP_PATH}"
           rm -rf "${DEST_PATH}/examples"
@@ -213,7 +213,7 @@ tasks:
       TMPDIR: '{{trimSuffix "/" (env "TMPDIR")| default "/tmp"}}/generate-assets'
       SEMVER_TAG: "{{.RUNNER_VERSION}}"
       OUTPUT_DIR: "{{.TMPDIR}}/{{.SEMVER_TAG}}"
-      ASSETS_DIR: debian/arduino-app-cli/home/arduino/.local/share/arduino-app-cli/assets
+      ASSETS_DIR: debian/arduino-app-cli/var/lib/arduino-app-cli/assets
       TESTDATA_DIR: internal/e2e/daemon/testdata/assets
     preconditions:
       - sh: '[ ! -d "{{.ASSETS_DIR}}/{{.SEMVER_TAG}}" ] || [ ! -d "{{.TESTDATA_DIR}}/{{.SEMVER_TAG}}" ]'

debian/arduino-app-cli/DEBIAN/postinst

@@ -1,6 +1,6 @@
 #!/bin/sh
 
-chown -R arduino:arduino /home/arduino/.local/share/arduino-app-cli
+chown -R arduino:arduino /var/lib/arduino-app-cli
 
 systemctl enable arduino-app-cli
 systemctl enable arduino-burn-bootloader

debian/arduino-app-cli/DEBIAN/preinst

@@ -23,3 +23,21 @@ if ! getent group "$SYSUPGRADE_GROUP" >/dev/null 2>&1; then
     groupadd --system "$SYSUPGRADE_GROUP"
 fi
 usermod -aG "$SYSUPGRADE_GROUP" "$APP_USER"
+
+delete_obsolete_files() {
+  OBSOLETE_DIR="/home/arduino/.local/share/arduino-app-cli/examples"
+    for i in "${OBSOLETE_DIR}"/*; do
+      rm -rf "${i}"/.cache;
+    done
+}
+
+if [ "$1" = "upgrade" ]; then
+  # if $2 is not empty, this is an upgrade
+  if [ -n "$2" ]; then
+    # check if this is an upgrade from an old version
+    if dpkg --compare-versions "$2" lt "0.9.0"; then
+        echo "Running pre-0.8.0 legacy cleanup/migration..."
+        delete_obsolete_files
+    fi
+  fi
+fi

debian/arduino-app-cli/DEBIAN/prerm

@@ -1,5 +1,43 @@
 #!/bin/sh
 
+set -e
 systemctl disable arduino-app-cli
 systemctl disable arduino-burn-bootloader
 systemctl disable arduino-avahi-serial.service
+
+# Function: cleanup_arduino_examples
+# Description: Stops running Arduino apps within example directories and
+#              removes associated cache files, but only if the root 
+#              examples directory exists.
+#
+# Arguments:
+#   $1 - The path to the root examples directory (EXAMPLES_DIR).
+#
+cleanup_arduino_examples() {
+    local EXAMPLES_DIR="$1"
+    
+    if [ -d "${EXAMPLES_DIR}" ]; then
+        local EXAMPLES=$(find "${EXAMPLES_DIR}" -maxdepth 1 -mindepth 1 -type d 2>/dev/null)
+        echo "Stopping apps and clearing cache in: ${EXAMPLES_DIR}"
+        for dir_path in ${EXAMPLES}; do
+            
+            # 1. Stop the application (suppress output and errors)
+            echo "  -> Stopping app in: ${dir_path}"
+            sudo -u arduino /usr/bin/arduino-app-cli app stop "${dir_path}" > /dev/null 2>&1 || true
+            
+            # 2. Remove the cache directory
+            local CACHE_PATH="${dir_path}/.cache"
+            
+            # Check if the cache directory exists before attempting to remove it
+            if [ -d "${CACHE_PATH}" ]; then
+                echo "  -> Removing cache: ${CACHE_PATH}"
+                rm -r "${CACHE_PATH}"
+            fi
+        done
+    fi
+}
+
+# Remove .cache located in packages prev to 0.9.0
+cleanup_arduino_examples /home/arduino/.local/share/arduino-app-cli/examples
+# Remove .cache for the current package 
+cleanup_arduino_examples /var/lib/arduino-app-cli/examples

debian/arduino-app-cli/etc/systemd/system/arduino-burn-bootloader.service

@@ -1,16 +1,16 @@
 [Unit]
 Description=Burn arduino zephyr bootloader on first boot
 After=fs-local.target
-ConditionPathExists=!/home/arduino/.local/share/arduino-app-cli/bootloader_burned.flag
+ConditionPathExists=!/var/lib/arduino-app-cli/bootloader_burned.flag
 
 [Service]
 Type=oneshot
 RemainAfterExit=true
 User=arduino
 Group=arduino
 ExecStart=/usr/bin/arduino-cli burn-bootloader -b arduino:zephyr:unoq -P jlink
-ExecStartPost=/bin/mkdir -p /home/arduino/.local/share/arduino-app-cli
-ExecStartPost=/bin/touch /home/arduino/.local/share/arduino-app-cli/bootloader_burned.flag
+ExecStartPost=/bin/mkdir -p /var/lib/arduino-app-cli
+ExecStartPost=/bin/touch /var/lib/arduino-app-cli/bootloader_burned.flag
 StandardOutput=journal
 StandardError=journal