Targeting friendlies with numpad keys on Windows does not work if numlock is toggled

[IonicPaul]

Using the shift + "select friendly" command will not work if numlock is enabled. If you do this, the game will react like you haven't pressed shift, and will select the friendly as a control object, rather than a target object. Turning off numlock will fix this instantly.

All other numpad inputs work just fine regardless of whether or not. My testing shows it only breaking on numbers 1-9.

[sfiera]

What is your “select friendly” key? Does it work differently with different choices of key?

[IonicPaul]

Typically I use numpad 7. As I said, it works if I turn numlock off. Other keys like numpad slash work regardless (I also tried "d" and that worked too).

[sfiera]

I guess my question would be: why does it work at all when num lock is enabled? Isn’t the purpose of num lock to make 0-9 register different keypresses from 0-9?

[IonicPaul]

Numlock makes those keys register number keypresses. Without numlock they are directional, pgup, pgdn, home, and end. Maybe Antares (or Ares?) reads these keys as raw inputs from the keyboard, or tracks them as the same. I doubt it's the latter because numlock off would mean the numpad would have arrow inputs, which would register as the in-game computer controls.

[sfiera]

So I looked into it a little and found glfw/glfw#946
Since num lock is (sometimes?) handled as a modifier key, it’s possible that the shift modifier key is ignored in some circumstances.
Test build available shortly in https://github.com/arescentral/antares/actions/runs/8429954570?pr=484

[IonicPaul]

Seems to be unchanged. I still have to turn numlock off to target correctly with the numpad numbers.