From 38aafa42773b16a343d2089a1f929fb78145eb2e Mon Sep 17 00:00:00 2001 From: Matej Zerovnik Date: Mon, 25 Jan 2021 13:37:16 +0100 Subject: [PATCH 1/2] No not overwrite critical / warning with OK hosts When checking multiple hosts, OK hosts can overwrite critical ones. --- check_vmware_ntp.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check_vmware_ntp.pl b/check_vmware_ntp.pl index 4f0227a..c934275 100644 --- a/check_vmware_ntp.pl +++ b/check_vmware_ntp.pl @@ -148,10 +148,10 @@ $ret = 2; } elsif ( abs($drift) > $warn) { $msg .= $host->get_property('summary.config.name') . " is " . ($drift) . " seconds off!"; - $ret = 1; + $ret = 1 if ($ret < 2); } else { $msg .= $host->get_property('summary.config.name') . " is within allowable drift (" . ($drift) . "s)"; - $ret = 0; + $ret = 0 if ($ret < 1); } if ( $ntp_srv_count > $peer_warn ) From 7191094fd494b23efa4c78a995e7ac5de394d429 Mon Sep 17 00:00:00 2001 From: Matej Zerovnik Date: Mon, 25 Jan 2021 14:48:53 +0100 Subject: [PATCH 2/2] Small fix Allow $ret = 0 when $ret == 3 to allow overwriting default UNKNOWN state. --- check_vmware_ntp.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check_vmware_ntp.pl b/check_vmware_ntp.pl index c934275..63ff3b3 100644 --- a/check_vmware_ntp.pl +++ b/check_vmware_ntp.pl @@ -148,10 +148,10 @@ $ret = 2; } elsif ( abs($drift) > $warn) { $msg .= $host->get_property('summary.config.name') . " is " . ($drift) . " seconds off!"; - $ret = 1 if ($ret < 2); + $ret = 1 if ($ret != 2); } else { $msg .= $host->get_property('summary.config.name') . " is within allowable drift (" . ($drift) . "s)"; - $ret = 0 if ($ret < 1); + $ret = 0 if ($ret != 1 || $ret != 2 ); } if ( $ntp_srv_count > $peer_warn )