From dae28b259c47f5f6ea8e13d0319179f404d69c57 Mon Sep 17 00:00:00 2001 From: Rob Berwick Date: Sun, 23 Feb 2025 10:45:04 +0000 Subject: [PATCH 1/2] fix: re-enable add udev rule functionality Re-enable to --add-udev-rule functionality in the blinkstick cli tool, --- src/scripts/main.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/scripts/main.py b/src/scripts/main.py index 2240b57..9ae1886 100644 --- a/src/scripts/main.py +++ b/src/scripts/main.py @@ -269,22 +269,13 @@ def main(): "--add-udev-rule", action="store_true", dest="udev", - help="Add udev rule to access BlinkSticks without root permissions. Must be run as root.", + help="Add udev rule to access BlinkSticks without root permissions. Must be run as root e.g. `sudo $(which blinkstick) --add-udev-rule`.", ) parser.add_option_group(group) (options, args) = parser.parse_args() - if options.serial is None: - sticks = find_all() - else: - sticks = [find_by_serial(options.serial)] - - if len(sticks) == 0: - print("BlinkStick with serial number " + options.backend + " not found...") - return 64 - # Global action if options.udev: @@ -307,6 +298,15 @@ def main(): print("Reboot your computer for changes to take effect") return 0 + if options.serial is None: + sticks = find_all() + else: + sticks = [find_by_serial(options.serial)] + + if len(sticks) == 0: + print("BlinkStick with serial number " + options.backend + " not found...") + return 64 + for stick in sticks: if options.inverse: stick.set_inverse(True) From 9988ed39629cd4ae027ae5e3a7d25424718d3300 Mon Sep 17 00:00:00 2001 From: Rob Berwick Date: Sun, 23 Feb 2025 10:54:09 +0000 Subject: [PATCH 2/2] fix: correct serial number reference in BlinkStick not found message --- src/scripts/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/scripts/main.py b/src/scripts/main.py index 9ae1886..b86d09e 100644 --- a/src/scripts/main.py +++ b/src/scripts/main.py @@ -304,7 +304,7 @@ def main(): sticks = [find_by_serial(options.serial)] if len(sticks) == 0: - print("BlinkStick with serial number " + options.backend + " not found...") + print("BlinkStick with serial number " + options.serial + " not found...") return 64 for stick in sticks: