From bc5f03de9a4b1d08d1c0c51f5e9a3cf1fd8f42c6 Mon Sep 17 00:00:00 2001 From: Brion Date: Fri, 24 Oct 2025 13:43:11 +0530 Subject: [PATCH 1/5] chore: remove unused import of Platform from embedded-flow.ts --- packages/javascript/src/models/embedded-flow.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/javascript/src/models/embedded-flow.ts b/packages/javascript/src/models/embedded-flow.ts index 5fd7c1251..a0d55ea1c 100644 --- a/packages/javascript/src/models/embedded-flow.ts +++ b/packages/javascript/src/models/embedded-flow.ts @@ -16,8 +16,6 @@ * under the License. */ -import {Platform} from './platforms'; - export enum EmbeddedFlowType { Authentication = 'AUTHENTICATION', Registration = 'REGISTRATION', From 78e808185dc8a9b33ba03ad705ee04e2f8a65d34 Mon Sep 17 00:00:00 2001 From: Brion Date: Fri, 24 Oct 2025 13:53:33 +0530 Subject: [PATCH 2/5] docs: add contributors section to README.md --- README.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/README.md b/README.md index 786905b79..f12ee5578 100644 --- a/README.md +++ b/README.md @@ -48,6 +48,14 @@ Follow these simple steps to get started with Asgardeo: Please read [Contributing Guide](CONTRIBUTING.md) for details on how to contribute to Asgardeo JavaScript SDKs. Refer to [General Contribution Guidelines](http://wso2.github.io/) for details on our code of conduct, and the process for submitting pull requests to us. +### Contributors ❤️ + +Hats off to all the people who have contributed to this project, including those who created issues and participated in discussions. 🙌 + + + + + ### Reporting issues We encourage you to report issues, improvements, and feature requests creating [Github Issues](https://github.com/asgardeo/javascript/issues). From 1c7c9a50c1627ca1cd1d3313fefe4b93890cafc0 Mon Sep 17 00:00:00 2001 From: Brion Date: Fri, 24 Oct 2025 14:12:01 +0530 Subject: [PATCH 3/5] fix: branding not fetched for other platforms --- packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx b/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx index ded01e55a..190acf596 100644 --- a/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx +++ b/packages/react/src/contexts/Asgardeo/AsgardeoProvider.tsx @@ -346,7 +346,7 @@ const AsgardeoProvider: FC> = ({ useEffect(() => { // TEMPORARY: Asgardeo V2 platform does not support branding preference yet. // Tracker: https://github.com/asgardeo/javascript/issues/212 - if (config.platform !== Platform.AsgardeoV2) { + if (config.platform === Platform.AsgardeoV2) { return; } From d76e5a4177a4d758bc7d4431f9651ca859d4cce3 Mon Sep 17 00:00:00 2001 From: Brion Date: Fri, 24 Oct 2025 14:12:27 +0530 Subject: [PATCH 4/5] fix: signin button issue with `AsgardeoV2` --- packages/react/src/AsgardeoReactClient.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react/src/AsgardeoReactClient.ts b/packages/react/src/AsgardeoReactClient.ts index db773b653..6f39bc008 100644 --- a/packages/react/src/AsgardeoReactClient.ts +++ b/packages/react/src/AsgardeoReactClient.ts @@ -48,6 +48,7 @@ import { Config, TokenExchangeRequestConfig, Platform, + isEmpty, } from '@asgardeo/browser'; import AuthAPI from './__temp__/api'; import getMeOrganizations from './api/getMeOrganizations'; @@ -334,7 +335,7 @@ class AsgardeoReactClient e const config: AsgardeoReactConfig = (await this.asgardeo.getConfigData()) as AsgardeoReactConfig; - if (config.platform === Platform.AsgardeoV2) { + if (config.platform === Platform.AsgardeoV2 && typeof arg1 === 'object' && !isEmpty(arg1)) { const sessionDataKey: string = new URL(window.location.href).searchParams.get('sessionDataKey'); return executeEmbeddedSignInFlowV2({ From 218f930c5f32b779c12af6c1a9fd0c5ea6879525 Mon Sep 17 00:00:00 2001 From: Brion Date: Fri, 24 Oct 2025 14:15:59 +0530 Subject: [PATCH 5/5] =?UTF-8?q?chore:=20add=20changeset=20=F0=9F=A6=8B?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .changeset/lazy-forks-sneeze.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/lazy-forks-sneeze.md diff --git a/.changeset/lazy-forks-sneeze.md b/.changeset/lazy-forks-sneeze.md new file mode 100644 index 000000000..3435aeab4 --- /dev/null +++ b/.changeset/lazy-forks-sneeze.md @@ -0,0 +1,6 @@ +--- +'@asgardeo/react': patch +'@asgardeo/javascript': patch +--- + +Fix `SignInButton` issue with `AsgardeoV2`