#272 Make more properties settable (Items, RequestAborted, IsHttps, Query, Cookies).

Author: Tratcher

src/Microsoft.AspNet.Http.Abstractions/HttpContext.cs

@@ -17,22 +17,22 @@ public abstract class HttpContext : IDisposable
 
         public abstract ConnectionInfo Connection { get; }
 
+        public abstract WebSocketManager WebSockets { get; }
+
         public abstract AuthenticationManager Authentication { get; }
 
         public abstract ClaimsPrincipal User { get; set; }
 
-        public abstract IDictionary<object, object> Items { get; }
+        public abstract IDictionary<object, object> Items { get; set; }
 
         public abstract IServiceProvider ApplicationServices { get; set; }
 
         public abstract IServiceProvider RequestServices { get; set; }
 
-        public abstract CancellationToken RequestAborted { get; }
+        public abstract CancellationToken RequestAborted { get; set; }
 
         public abstract ISessionCollection Session { get; }
 
-        public abstract WebSocketManager WebSockets { get; }
-
         public abstract void Abort();
 
         public abstract void Dispose();

src/Microsoft.AspNet.Http.Abstractions/HttpRequest.cs

@@ -27,7 +27,7 @@ public abstract class HttpRequest
         /// Returns true if the owin.RequestScheme is https.
         /// </summary>
         /// <returns>true if this request is using https; otherwise, false.</returns>
-        public abstract bool IsHttps { get; }
+        public abstract bool IsHttps { get; set; }
 
         /// <summary>
         /// Gets or set the Host header. May include the port.
@@ -57,7 +57,7 @@ public abstract class HttpRequest
         /// Gets the query value collection parsed from owin.RequestQueryString.
         /// </summary>
         /// <returns>The query value collection parsed from owin.RequestQueryString.</returns>
-        public abstract IReadableStringCollection Query { get; }
+        public abstract IReadableStringCollection Query { get; set; }
 
         /// <summary>
         /// Gets or set the owin.RequestProtocol.
@@ -75,7 +75,7 @@ public abstract class HttpRequest
         /// Gets the collection of Cookies for this request.
         /// </summary>
         /// <returns>The collection of Cookies for this request.</returns>
-        public abstract IReadableStringCollection Cookies { get; }
+        public abstract IReadableStringCollection Cookies { get; set; }
 
         /// <summary>
         /// Gets or sets the Content-Length header

src/Microsoft.AspNet.Http.Abstractions/QueryString.cs

@@ -111,6 +111,7 @@ public static QueryString FromUriComponent([NotNull] Uri uri)
         /// </summary>
         /// <param name="name">The un-encoded parameter name</param>
         /// <param name="value">The un-encoded parameter value</param>
+        /// <returns>The resulting QueryString</returns>
         public static QueryString Create(string name, string value)
         {
             return new QueryString("?" + UrlEncoder.Default.UrlEncode(name) + '=' + UrlEncoder.Default.UrlEncode(value));
@@ -120,7 +121,7 @@ public static QueryString Create(string name, string value)
         /// Creates a query string composed from the given name value pairs.
         /// </summary>
         /// <param name="parameters"></param>
-        /// <returns></returns>
+        /// <returns>The resulting QueryString</returns>
         public static QueryString Create(IEnumerable<KeyValuePair<string, string>> parameters)
         {
             var builder = new StringBuilder();
@@ -137,6 +138,30 @@ public static QueryString Create(IEnumerable<KeyValuePair<string, string>> param
             return new QueryString(builder.ToString());
         }
 
+        /// <summary>
+        /// Creates a query string composed from the given name value pairs.
+        /// </summary>
+        /// <param name="parameters"></param>
+        /// <returns>The resulting QueryString</returns>
+        public static QueryString Create(IEnumerable<KeyValuePair<string, string[]>> parameters)
+        {
+            var builder = new StringBuilder();
+            bool first = true;
+            foreach (var pair in parameters)
+            {
+                foreach (var value in pair.Value)
+                {
+                    builder.Append(first ? "?" : "&");
+                    first = false;
+                    builder.Append(UrlEncoder.Default.UrlEncode(pair.Key));
+                    builder.Append("=");
+                    builder.Append(UrlEncoder.Default.UrlEncode(value));
+                }
+            }
+
+            return new QueryString(builder.ToString());
+        }
+
         public QueryString Add(QueryString other)
         {
             if (!HasValue || Value.Equals("?", StringComparison.Ordinal))

src/Microsoft.AspNet.Http.Features/IHttpRequestLifetimeFeature.cs

@@ -7,7 +7,7 @@ namespace Microsoft.AspNet.Http.Features
 {
     public interface IHttpRequestLifetimeFeature
     {
-        CancellationToken RequestAborted { get; }
+        CancellationToken RequestAborted { get; set; }
         void Abort();
     }
 }

src/Microsoft.AspNet.Http/Constants.cs

@@ -5,7 +5,8 @@ namespace Microsoft.AspNet.Http.Internal
 {
     internal static class Constants
     {
-        internal const string Https = "HTTPS";
+        internal const string Http = "http";
+        internal const string Https = "https";
 
         internal static class BuilderProperties
         {

src/Microsoft.AspNet.Http/DefaultHttpContext.cs

@@ -69,7 +69,7 @@ private IHttpAuthenticationFeature HttpAuthenticationFeature
 
         private IHttpRequestLifetimeFeature LifetimeFeature
         {
-            get { return _lifetime.Fetch(_features); }
+            get { return _lifetime.Fetch(_features) ?? _lifetime.Update(_features, new HttpRequestLifetimeFeature()); }
         }
 
         private ISessionFeature SessionFeature
@@ -103,6 +103,7 @@ public override ClaimsPrincipal User
         public override IDictionary<object, object> Items
         {
             get { return ItemsFeature.Items; }
+            set { ItemsFeature.Items = value; }
         }
 
         public override IServiceProvider ApplicationServices
@@ -117,19 +118,10 @@ public override IServiceProvider RequestServices
             set { ServiceProvidersFeature.RequestServices = value; }
         }
 
-        public int Revision { get { return _features.Revision; } }
-
         public override CancellationToken RequestAborted
         {
-            get
-            {
-                var lifetime = LifetimeFeature;
-                if (lifetime != null)
-                {
-                    return lifetime.RequestAborted;
-                }
-                return CancellationToken.None;
-            }
+            get { return LifetimeFeature.RequestAborted; }
+            set { LifetimeFeature.RequestAborted = value; }
         }
 
         public override ISessionCollection Session
@@ -167,11 +159,7 @@ public override WebSocketManager WebSockets
 
         public override void Abort()
         {
-            var lifetime = LifetimeFeature;
-            if (lifetime != null)
-            {
-                lifetime.Abort();
-            }
+            LifetimeFeature.Abort();
         }
 
         public override void Dispose()

src/Microsoft.AspNet.Http/DefaultHttpRequest.cs

@@ -101,6 +101,7 @@ public override string Scheme
         public override bool IsHttps
         {
             get { return string.Equals(Constants.Https, Scheme, StringComparison.OrdinalIgnoreCase); }
+            set { Scheme = value ? Constants.Https : Constants.Http; }
         }
 
         public override HostString Host
@@ -112,6 +113,7 @@ public override HostString Host
         public override IReadableStringCollection Query
         {
             get { return QueryFeature.Query; }
+            set { QueryFeature.Query = value; }
         }
 
         public override string Protocol
@@ -128,6 +130,7 @@ public override IHeaderDictionary Headers
         public override IReadableStringCollection Cookies
         {
             get { return RequestCookiesFeature.Cookies; }
+            set { RequestCookiesFeature.Cookies = value; }
         }
 
         public override string ContentType

src/Microsoft.AspNet.Http/Features/HttpRequestLifetimeFeature.cs

@@ -0,0 +1,17 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System.Threading;
+using Microsoft.AspNet.Http.Features;
+
+namespace Microsoft.AspNet.Http.Features.Internal
+{
+    public class HttpRequestLifetimeFeature : IHttpRequestLifetimeFeature
+    {
+        public CancellationToken RequestAborted { get; set; }
+
+        public void Abort()
+        {
+        }
+    }
+}

src/Microsoft.AspNet.Http/Features/IItemsFeature.cs

@@ -7,6 +7,6 @@ namespace Microsoft.AspNet.Http.Features.Internal
 {
     public interface IItemsFeature
     {
-        IDictionary<object, object> Items { get; }
+        IDictionary<object, object> Items { get; set; }
     }
 }

src/Microsoft.AspNet.Http/Features/IQueryFeature.cs

@@ -5,6 +5,6 @@ namespace Microsoft.AspNet.Http.Features.Internal
 {
     public interface IQueryFeature
     {
-        IReadableStringCollection Query { get; }
+        IReadableStringCollection Query { get; set; }
     }
 }