Lagrange-Interpolator: Name amendments for clarity + remove MulAssign (See PR note)

Author: yfnaji

crates/RustQuant_math/src/interpolation/lagrange_interpolator.rs

@@ -69,20 +69,20 @@ where
         })
     }
 
-    fn cardinal_function(&self, point: IndexType, pivot: IndexType, index: usize) -> ValueType {
-        let mut lagrange_basis: ValueType = ValueType::one();
+    fn lagrange_basis(&self, point: IndexType, node: IndexType, index: usize) -> ValueType {
+        let mut basis: ValueType = ValueType::one();
         for (i, x) in self.xs.iter().enumerate() {
             if i != index {
-                lagrange_basis *= (point - *x) / (pivot - *x);
+                basis *= (point - *x) / (node - *x);
             }
         }
-        lagrange_basis
+        basis
     }
 
     fn lagrange_polynomial(&self, point: IndexType) -> ValueType {
         let mut polynomial: ValueType = ValueType::zero();
         for (i, (x, y)) in self.xs.iter().zip(&self.ys).enumerate() {
-            polynomial += *y * self.cardinal_function(point, *x, i);
+            polynomial += *y * self.lagrange_basis(point, *x, i);
 
         }
         polynomial

crates/RustQuant_math/src/interpolation/mod.rs

@@ -26,7 +26,7 @@ pub use lagrange_interpolator::*;
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 /// Trait describing requirements to be interpolated.
-pub trait InterpolationValue: num::Num + AddAssign + MulAssign + std::fmt::Debug + Copy + Clone + Sized {}
+pub trait InterpolationValue: num::Num + AddAssign + std::fmt::Debug + Copy + Clone + Sized {}
 
 /// Trait describing requirements to be an index of interpolation.
 pub trait InterpolationIndex: