diff --git a/mlops-multi-account-cdk/mlops-sm-project-template/seed_code/build_app/source_scripts/evaluate/evaluate_xgboost/main.py b/mlops-multi-account-cdk/mlops-sm-project-template/seed_code/build_app/source_scripts/evaluate/evaluate_xgboost/main.py index 7027811e..84bce642 100644 --- a/mlops-multi-account-cdk/mlops-sm-project-template/seed_code/build_app/source_scripts/evaluate/evaluate_xgboost/main.py +++ b/mlops-multi-account-cdk/mlops-sm-project-template/seed_code/build_app/source_scripts/evaluate/evaluate_xgboost/main.py @@ -37,7 +37,29 @@ logger.debug("Starting evaluation.") model_path = "/opt/ml/processing/model/model.tar.gz" with tarfile.open(model_path) as tar: - tar.extractall(path=".") + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=".") logger.debug("Loading xgboost model.") model = pickle.load(open("xgboost-model", "rb")) diff --git a/mlops-template-gitlab/seedcode/mlops-gitlab-project-seedcode-model-build/pipelines/abalone/evaluate.py b/mlops-template-gitlab/seedcode/mlops-gitlab-project-seedcode-model-build/pipelines/abalone/evaluate.py index 6ddf06d8..bb19e8e3 100644 --- a/mlops-template-gitlab/seedcode/mlops-gitlab-project-seedcode-model-build/pipelines/abalone/evaluate.py +++ b/mlops-template-gitlab/seedcode/mlops-gitlab-project-seedcode-model-build/pipelines/abalone/evaluate.py @@ -21,7 +21,29 @@ logger.debug("Starting evaluation.") model_path = "/opt/ml/processing/model/model.tar.gz" with tarfile.open(model_path) as tar: - tar.extractall(path=".") + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=".") logger.debug("Loading xgboost model.") model = pickle.load(open("xgboost-model", "rb")) diff --git a/multi-branch-mlops-train/pipelines/abalone/evaluate.py b/multi-branch-mlops-train/pipelines/abalone/evaluate.py index 6ddf06d8..bb19e8e3 100644 --- a/multi-branch-mlops-train/pipelines/abalone/evaluate.py +++ b/multi-branch-mlops-train/pipelines/abalone/evaluate.py @@ -21,7 +21,29 @@ logger.debug("Starting evaluation.") model_path = "/opt/ml/processing/model/model.tar.gz" with tarfile.open(model_path) as tar: - tar.extractall(path=".") + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=".") logger.debug("Loading xgboost model.") model = pickle.load(open("xgboost-model", "rb")) diff --git a/serverless-inf/seedcode/build/pipelines/abalone/evaluate.py b/serverless-inf/seedcode/build/pipelines/abalone/evaluate.py index 6ddf06d8..bb19e8e3 100644 --- a/serverless-inf/seedcode/build/pipelines/abalone/evaluate.py +++ b/serverless-inf/seedcode/build/pipelines/abalone/evaluate.py @@ -21,7 +21,29 @@ logger.debug("Starting evaluation.") model_path = "/opt/ml/processing/model/model.tar.gz" with tarfile.open(model_path) as tar: - tar.extractall(path=".") + + import os + + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=".") logger.debug("Loading xgboost model.") model = pickle.load(open("xgboost-model", "rb"))