I think BAKAuthenticatingCreateMessageCoordinator leaks due to typo in startCreation method

[hacknicity]

Hi Soroush, I've been looking over the code because I'm keen to use Coordinators in my next project. I have stumbled across what looks like a simple typo that I think will cause a reference cycle in BAKAuthenticatingCreateMessageCoordinator. In the startCreation method:

- (void)startCreation {
    self.createMessageCoordinator.delegate = self;
    [self.createMessageCoordinator start];
    [self.childCoordinators addObject:self.childCoordinators];  // <<-- here
}

the object being added to the childCoordinators array should be self.createMessageCoordinator and not self.childCoordinators.

[khanlou]

😱

[khanlou]

if it's easy to make a pull request, i'd greatly appreciate one. if you can't, no big deal

[hacknicity]

Sure. I need to learn how to do that first, but now's as good a time as any! You might have to wait until tomorrow as it's early evening in the UK and I have other stuff I need to do.

[khanlou]

no problem! let me know if i can help teach you how to make a pull request. it's a very useful skill!

[hacknicity]

Pull request created: #9