can't handle errors (app crash) when using packetSerial and usb disconnects (Windows/0.9.8)

[moebiussurfing]

hey @bakercp ,
I used the addon and is working really fine! (Windows 10, OF 0.9.8 with ofxSerial master branch).

But when using the packetSerial mode / example, the OF app crashes when disconnected the USB cable. (example_packet_serial and example_SLIPPacketSerial)

I used the other examples templates without packetSerial, and when the cable is disconected the OF app do not crashes. Btw I used to reconnect the serial when the cable is plugged again, and the OF app contiues working fine.

I would like to handle this errors and avoid this crash, because usually the app window can't be closed, and I have to reboot the machine to get it working again.
(I would like to use the packetSerial arduino library, so I don't have to handle the start/finish bytes by hand...)

[moebiussurfing]

ps: the error is a floating window (with a red X circle) that says:
Debug Error!
Microsoft Visual C++ runtime Library
...
abort() has been called

[bakercp]

Hm. It sounds like an exception that isn't being handled. Can you put try / catch blocks around the reading / writing / update portions and see if you can catch the exception?

[moebiussurfing]

ok. thanks @bakercp !

on the example_packetSerial it works just doing this:

void ofApp::update()
{
 try {
    // Create a byte buffer.
    ofx::IO::ByteBuffer buffer("Frame Number: " + ofToString(ofGetFrameNum()));

    // Send the byte buffer.
    // ofx::IO::PacketSerialDevice will encode the buffer, send it to the
    // receiver, and send a packet marker.
    device.send(buffer);
  }
 catch (const std::exception& exc)
    {
        ofLogError("ofApp::update") << exc.what();
    }
}

but, on this other function, even inserting try / catch, the app crashes, so I need to comment all the content. (I don't know what kind of errors this function detects, maybe malformed packets not related to the serial device...)

void ofApp::onSerialError(const ofx::IO::SerialBufferErrorEventArgs& args)
{
    // Errors and their corresponding buffer (if any) will show up here.
    SerialMessage message(args.getBuffer().toString(),
                          args.getException().displayText(),
                          500);

    serialMessages.push_back(message);
}

[moebiussurfing]

... but it's ok. all working really fine. thanks for this addon!