From 743040b35ea90ae4370ec9badbf0098302601233 Mon Sep 17 00:00:00 2001 From: Tyler French Date: Thu, 18 Dec 2025 14:49:21 -0500 Subject: [PATCH 1/2] SpliceBlobRequest.blob_digest should be required --- build/bazel/remote/execution/v2/remote_execution.proto | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/build/bazel/remote/execution/v2/remote_execution.proto b/build/bazel/remote/execution/v2/remote_execution.proto index 40e34917..6eb0e18d 100644 --- a/build/bazel/remote/execution/v2/remote_execution.proto +++ b/build/bazel/remote/execution/v2/remote_execution.proto @@ -1995,15 +1995,17 @@ message SpliceBlobRequest { // omitted. string instance_name = 1; - // Expected digest of the spliced blob. The client SHOULD set this field due + // Expected digest of the spliced blob. The client MUST set this field due // to the following reasons: // 1. It allows the server to perform an early existence check of the blob - // before spending the splicing effort, as described in the - // [ContentAddressableStorage.SpliceBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SpliceBlob] + // or existing chunks that assemble the blob before spending the splicing + // effort, as described in the [ContentAddressableStorage.SpliceBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SpliceBlob] // documentation. // 2. It allows servers with different storage backends to dispatch the // request to the correct storage backend based on the size and/or the // hash of the blob. + // 3. If chunking information already exists for the blob, it allows + // the server to keep the existing chunking information or replace it with new chunking information. Digest blob_digest = 2; // The ordered list of digests of the chunks which need to be concatenated to From db45d6d4e0731eeeed4e136cae1c3231645c59f9 Mon Sep 17 00:00:00 2001 From: Tyler French Date: Tue, 13 Jan 2026 10:58:57 -0500 Subject: [PATCH 2/2] Fix comment formatting in remote_execution.proto --- build/bazel/remote/execution/v2/remote_execution.proto | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build/bazel/remote/execution/v2/remote_execution.proto b/build/bazel/remote/execution/v2/remote_execution.proto index 6eb0e18d..8224f1a1 100644 --- a/build/bazel/remote/execution/v2/remote_execution.proto +++ b/build/bazel/remote/execution/v2/remote_execution.proto @@ -2005,7 +2005,8 @@ message SpliceBlobRequest { // request to the correct storage backend based on the size and/or the // hash of the blob. // 3. If chunking information already exists for the blob, it allows - // the server to keep the existing chunking information or replace it with new chunking information. + // the server to keep the existing chunking information or replace it with + // new chunking information. Digest blob_digest = 2; // The ordered list of digests of the chunks which need to be concatenated to