core/ and manager/ write permissions

[yurkobb]

Hi there! Thanks for the great addon. I'm writing because the I was installing the addon in an environment where core/ and manager/ were (mostly) readonly for the web server process, and the addon requires to put some files there. The problem is that when installing it fails to install the files but still prints "Successfully installed package colorpicker-1.0.2-rc2". Here's the full log on my machine:

Attempting to install package with signature: colorpicker-1.0.2-rc2
Package found...now preparing to install.
Grabbing package workspace...
Workspace environment initiated, now installing package...
/home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/mgr/input is not writable and permissions could not be modified.
xPDOCacheManager->copyFile(): Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/0/colorpicker.class.php to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/mgr/input/colorpicker.class.php
Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/0/colorpicker.class.php to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/mgr/input/colorpicker.class.php; could not create directory.
Could not copy /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/0/ to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/mgr/input/colorpicker.class.php
/home/yurb/public_html/mgenergies/manager/templates/default/element/tv/renders/input is not writable and permissions could not be modified.
xPDOCacheManager->copyFile(): Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/1/colorpicker.tpl to /home/yurb/public_html/mgenergies/manager/templates/default/element/tv/renders/input/colorpicker.tpl
Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/1/colorpicker.tpl to /home/yurb/public_html/mgenergies/manager/templates/default/element/tv/renders/input/colorpicker.tpl; could not create directory.
Could not copy /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/1/ to /home/yurb/public_html/mgenergies/manager/templates/default/element/tv/renders/input/colorpicker.tpl
/home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/mgr/properties is not writable and permissions could not be modified.
xPDOCacheManager->copyFile(): Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/2/colorpicker.php to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/mgr/properties/colorpicker.php
Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/2/colorpicker.php to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/mgr/properties/colorpicker.php; could not create directory.
Could not copy /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/2/ to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/mgr/properties/colorpicker.php
/home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/web/output is not writable and permissions could not be modified.
xPDOCacheManager->copyFile(): Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/3/colorpicker.class.php to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/web/output/colorpicker.class.php
Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/3/colorpicker.class.php to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/web/output/colorpicker.class.php; could not create directory.
Could not copy /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/3/ to /home/yurb/public_html/mgenergies/core/model/modx/processors/element/tv/renders/web/output/colorpicker.class.php
/home/yurb/public_html/mgenergies/manager/templates/default/element/tv/renders/properties is not writable and permissions could not be modified.
xPDOCacheManager->copyFile(): Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/4/colorpicker.tpl to /home/yurb/public_html/mgenergies/manager/templates/default/element/tv/renders/properties/colorpicker.tpl
Could not copy file /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/4/colorpicker.tpl to /home/yurb/public_html/mgenergies/manager/templates/default/element/tv/renders/properties/colorpicker.tpl; could not create directory.
Could not copy /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116/4/ to /home/yurb/public_html/mgenergies/manager/templates/default/element/tv/renders/properties/colorpicker.tpl
Attempting to preserve files at /home/yurb/public_html/mgenergies/core/components/colorpicker into archive /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116.5.preserved.zip
Attempting to preserve files at /home/yurb/public_html/mgenergies/assets/components/colorpicker into archive /home/yurb/public_html/mgenergies/core/packages/colorpicker-1.0.2-rc2/modCategory/081bd656ebfb522109b113daf08e8116.6.preserved.zip
Successfully installed package colorpicker-1.0.2-rc2

I think you could write about the permissions requirements somewhere in the readme, and make the installer stop and print a message if the files weren't copied.

Thanks,
Yury

[benjamin-vauchel]

Thanks for the report. I'll take a look.

[Mark-H]

If I can just add, I don't think it should write to any of the core/manager folders directly - it should go into core/components and assets/components instead.

[benjamin-vauchel]

Is it possible to create custom TVs in assets and core components directory ?

The documentation tells to create them in core and manager directories : http://rtfm.modx.com/display/revolution20/Adding+a+Custom+TV+Output+Type

[Mark-H]

Hmm, now I don't have a lot of experience building custom TVs myself, but it looks like that doc is way old. I noticed there was a newer one specifically for 2.2: http://rtfm.modx.com/display/revolution20/Adding+a+Custom+TV+Type+-+MODX+2.2 which looks more like code I've seen in use elsewhere and puts the files where they should be, in the core/components dir.

I'll see if I can get someone more knowledgeable to look into the older doc pages to see if they are still applicable at all. The way that doc does it looks to me like the way you would add new TV types for in the core, but not for packaging them up and distributing standalone..

[Mark-H]

Just got it confirmed that the MODX 2.2 one should be used now. The two other ones are only for pre-2.2 and for core patches, granted it has to be really good and scalable to warrant being included in the core vs being in a package.

The docs will be clarified soon for this.

[benjamin-vauchel]

Great ! Thanks Mark-H, I didn't notice the doc update.

First, I think I'll add a preinstall paths validator and then I'll refactor the code for MODx 2.3 which will not need the "Pathin Plugin".