From 32642b371cbc640b9224e2a0c4990bb5e021e30b Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Fri, 19 Dec 2025 22:29:49 +0200 Subject: [PATCH 1/8] Apply Repo-Review suggestion PP302: Sets a minimum pytest to at least 6 or 9 --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index dbed082..77cd975 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -61,6 +61,7 @@ tag_prefix = "" parentdir_prefix = "" [tool.pytest.ini_options] +minversion = "6" norecursedirs = ["data"] doctest_optionflags = ["NORMALIZE_WHITESPACE", "IGNORE_EXCEPTION_DETAIL"] From b2a64fb109c75edbfcac7edd8e3f8add899b4ba4 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Fri, 19 Dec 2025 22:30:27 +0200 Subject: [PATCH 2/8] Apply Repo-Review suggestion PP303: Sets the test paths --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index 77cd975..4f716b3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -62,6 +62,7 @@ parentdir_prefix = "" [tool.pytest.ini_options] minversion = "6" +testpaths = ["tests"] norecursedirs = ["data"] doctest_optionflags = ["NORMALIZE_WHITESPACE", "IGNORE_EXCEPTION_DETAIL"] From 68f3b485a677634b554a23c4d3b44fb952a33840 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Fri, 19 Dec 2025 22:31:04 +0200 Subject: [PATCH 3/8] Apply Repo-Review suggestion PP304: Sets the log level in pytest --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index 4f716b3..1708cd5 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -63,6 +63,7 @@ parentdir_prefix = "" [tool.pytest.ini_options] minversion = "6" testpaths = ["tests"] +log_level = "INFO" norecursedirs = ["data"] doctest_optionflags = ["NORMALIZE_WHITESPACE", "IGNORE_EXCEPTION_DETAIL"] From 86b8f99e5ff2bfe99361cf90a62b3289373dcce7 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Fri, 19 Dec 2025 22:32:34 +0200 Subject: [PATCH 4/8] Apply Repo-Review suggestion PP305: Specifies strict xfail --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index 1708cd5..d467fa7 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -64,6 +64,7 @@ parentdir_prefix = "" minversion = "6" testpaths = ["tests"] log_level = "INFO" +xfail_strict = true norecursedirs = ["data"] doctest_optionflags = ["NORMALIZE_WHITESPACE", "IGNORE_EXCEPTION_DETAIL"] From c5481af6fb63249efd700ad6b96f2abffd72ffbc Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Fri, 19 Dec 2025 22:33:33 +0200 Subject: [PATCH 5/8] Apply Repo-Review suggestions PP306: Specifies strict config PP307: Specifies strict markers PP308: Specifies useful pytest summary --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index d467fa7..c22b457 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -65,6 +65,7 @@ minversion = "6" testpaths = ["tests"] log_level = "INFO" xfail_strict = true +addopts = ["-ra", "--strict-config", "--strict-markers"] norecursedirs = ["data"] doctest_optionflags = ["NORMALIZE_WHITESPACE", "IGNORE_EXCEPTION_DETAIL"] From 810a67edf5c87d670f78ba4846a96d96c5bf05e3 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Fri, 19 Dec 2025 22:34:37 +0200 Subject: [PATCH 6/8] Apply Repo-Review suggestion PP309: Filter warnings specified --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index c22b457..da988be 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -66,6 +66,7 @@ testpaths = ["tests"] log_level = "INFO" xfail_strict = true addopts = ["-ra", "--strict-config", "--strict-markers"] +filterwarnings = ["error"] norecursedirs = ["data"] doctest_optionflags = ["NORMALIZE_WHITESPACE", "IGNORE_EXCEPTION_DETAIL"] From 36b47705e736a5bfec3a1cf9a5b2adbb858398d5 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Fri, 19 Dec 2025 22:35:22 +0200 Subject: [PATCH 7/8] Remove extra empty line --- pyproject.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index da988be..0432b66 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -70,7 +70,6 @@ filterwarnings = ["error"] norecursedirs = ["data"] doctest_optionflags = ["NORMALIZE_WHITESPACE", "IGNORE_EXCEPTION_DETAIL"] - [tool.coverage.run] branch = true parallel = true From 50d9196748dc989e23a6b3cae7fb7a91b30ce745 Mon Sep 17 00:00:00 2001 From: "Christopher J. Markiewicz" Date: Sat, 20 Dec 2025 08:43:07 -0500 Subject: [PATCH 8/8] chore(tox): Ignore warning for minimum dependencies --- tox.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/tox.ini b/tox.ini index 12a3b67..9dcdad2 100644 --- a/tox.ini +++ b/tox.ini @@ -63,6 +63,7 @@ commands = coverage erase coverage run -p -m bids_validator tests/data/bids-examples/ds000117 python -m pytest --doctest-modules --cov . --cov-append --cov-report term \ + min: -Wignore \ --junitxml=test-results.xml {posargs} coverage xml