From 44c633af14bf488a22dd2b427461230cabde86db Mon Sep 17 00:00:00 2001 From: Abhinav Dangeti Date: Fri, 23 May 2025 12:46:32 -0600 Subject: [PATCH 1/2] MB-66395: API change to accommodate batch execution of queries --- segment_vector.go | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/segment_vector.go b/segment_vector.go index a57e0b4..ee2a59e 100644 --- a/segment_vector.go +++ b/segment_vector.go @@ -19,6 +19,7 @@ package segment import ( "encoding/json" + "time" "github.com/RoaringBitmap/roaring/v2" ) @@ -66,16 +67,21 @@ type VectorIndex interface { Size() uint64 } +const DefaultBatchExecutionDelay = time.Duration(100 * time.Millisecond) + +type InterpretVectorIndexOptions struct { + Batch bool + BatchExecutionDelay time.Duration +} + type VectorSegment interface { Segment - InterpretVectorIndex(field string, requiresFiltering bool, except *roaring.Bitmap) ( - VectorIndex, error) + InterpretVectorIndex(field string, requiresFiltering bool, except *roaring.Bitmap, + options InterpretVectorIndexOptions) (VectorIndex, error) } type VecPosting interface { Number() uint64 - Score() float32 - Size() int } From 37f101287093064d45545fc6899b6a0ab0523c19 Mon Sep 17 00:00:00 2001 From: Abhinav Dangeti Date: Tue, 27 May 2025 14:24:24 -0600 Subject: [PATCH 2/2] Pointer `InterpretVectorIndexOptions` --- segment_vector.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/segment_vector.go b/segment_vector.go index ee2a59e..b914ea9 100644 --- a/segment_vector.go +++ b/segment_vector.go @@ -77,7 +77,7 @@ type InterpretVectorIndexOptions struct { type VectorSegment interface { Segment InterpretVectorIndex(field string, requiresFiltering bool, except *roaring.Bitmap, - options InterpretVectorIndexOptions) (VectorIndex, error) + options *InterpretVectorIndexOptions) (VectorIndex, error) } type VecPosting interface {