Skip to content

Commit e392b97

Browse files
committed
Fix Maven release:
- add `ignoreSnapshots` argument to mvn command - disable maven project validation as it is no longer relevant
1 parent ccd477f commit e392b97

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

release.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
#!/usr/bin/env bash
22
export JAVA_HOME=$($1)
33
shift
4-
echo "mvn -f $1 -B release:$2 $3 -P gpg -DskipTests -Dgpg.pinentry-mode=default -Darguments=\"-Dgpg.pinentry-mode=default -DskipTests\" -Dgoals=\"source:jar-no-fork javadoc:jar deploy\""
5-
mvn -f $1 -B release:$2 $3 -P gpg -DskipTests -Dgpg.pinentry-mode=default -Darguments="-Dgpg.pinentry-mode=default -DskipTests" -Dgoals="source:jar-no-fork javadoc:jar deploy"
4+
echo "mvn -f $1 -B release:$2 $3 -P gpg -DskipTests -DignoreSnapshots=true -Dgpg.pinentry-mode=default -Darguments=\"-Dgpg.pinentry-mode=default -DskipTests\" -Dgoals=\"source:jar-no-fork javadoc:jar deploy\""
5+
mvn -f $1 -B release:$2 $3 -P gpg -DskipTests -DignoreSnapshots=true -Dgpg.pinentry-mode=default -Darguments="-Dgpg.pinentry-mode=default -DskipTests" -Dgoals="source:jar-no-fork javadoc:jar deploy"
6+
7+
# mvn release:prepare -DignoreSnapshots=true -Pgpg -DskipTests -Dgoals="source:jar-no-fork javadoc:jar deploy"

src/main/java/io/bootique/tools/release/service/validation/DefaultValidatePomService.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import java.net.URL;
1616
import java.nio.file.Files;
1717
import java.nio.file.Path;
18+
import java.util.Collections;
1819
import java.util.List;
1920
import java.util.Map;
2021
import java.util.Optional;
@@ -74,10 +75,8 @@ public Map<String, List<String>> validatePom(String repoName) {
7475
}
7576

7677
public List<String> validate(Document document) {
77-
return validators.stream()
78-
.map(v -> v.apply(document))
79-
.flatMap(Optional::stream)
80-
.toList();
78+
return Collections.emptyList();
79+
// TODO: do we need any validations?
8180
}
8281

8382
Optional<String> validateDependencies(Document document) {

src/test/java/io/bootique/tools/release/service/validation/ValidatePomTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ void validatePomFail() throws URISyntaxException {
4242
Path path = Path.of(Objects.requireNonNull(url).toURI());
4343
mockPreferenceService.set(GitService.BASE_PATH_PREFERENCE, path);
4444
Map<String, List<String>> validated = validatePomService.validatePom("");
45-
assertEquals(1, validated.size());
45+
assertEquals(0, validated.size());
4646
}
4747

4848
@Test

0 commit comments

Comments
 (0)