db.id(undefined) returns new id instead of null

Author: boycce

lib/_types.js

@@ -71,15 +71,21 @@ module.exports = {
   forceArray: function(value) {
     return this.isArray(value)? value : [value]
   },
+
+  /**
+   * @typedef {string} HexString
+   * @description A hex string of 24 characters
+   */
 
   /**
    * Casts to ObjectId
-   * @param {string|ObjectId} str - string = hex string
-   * @return {ObjectId}
+   * @param {HexString|ObjectId} [value] - empty string = new ObjectId('')
    */
-  id: function(str) {
-    if (str == null) return new ObjectId()
-    return typeof str === 'string' ? ObjectId.createFromHexString(str) : str
+  id: function(value) {
+    if (value === undefined) return new ObjectId()
+    else if (typeof value === 'string') return ObjectId.createFromHexString(value)
+    else if (value instanceof ObjectId) return value
+    else throw new Error(`Monastery: invalid value "${value}" passed to id(value?: HexString|ObjectId).`)
   },
 
   inArray: (array, key, value) => {