Skip to content

Commit 477a09a

Browse files
kamathkamath
committed
e2e tests pass
1 parent 74e6d51 commit 477a09a

File tree

7 files changed

+17
-74
lines changed

7 files changed

+17
-74
lines changed

‎examples/__init__.py‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
load_dotenv(override=True)
99

1010
# Make sure we have the required environment variables
11-
BROWSERBASE_CONNECT_URL = os.environ.get(
12-
"BROWSERBASE_CONNECT_URL", "wss://connect.browserbase.com"
13-
)
1411
_BROWSERBASE_API_KEY = os.environ.get("BROWSERBASE_API_KEY")
1512
if not _BROWSERBASE_API_KEY:
1613
raise ValueError("BROWSERBASE_API_KEY is not set in environment")

‎examples/playwright_captcha.py‎

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
from playwright.sync_api import Playwright, ConsoleMessage, sync_playwright
22

33

4-
from examples import (
5-
BROWSERBASE_API_KEY,
6-
BROWSERBASE_PROJECT_ID,
7-
BROWSERBASE_CONNECT_URL,
8-
bb,
9-
)
4+
from examples import BROWSERBASE_PROJECT_ID, bb
105

116
DEFAULT_CAPTCHA_URL = "https://www.google.com/recaptcha/api2/demo"
127
OVERRIDE_TIMEOUT = 60000 # 60 seconds, adjust as needed
@@ -19,11 +14,7 @@ def run(playwright: Playwright) -> None:
1914
assert session.status == "RUNNING", f"Session status is {session.status}"
2015

2116
# Connect to the remote session
22-
connect_url = (
23-
f"{BROWSERBASE_CONNECT_URL}?sessionId={session.id}&apiKey={BROWSERBASE_API_KEY}"
24-
)
25-
chromium = playwright.chromium
26-
browser = chromium.connect_over_cdp(connect_url)
17+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
2718
context = browser.contexts[0]
2819
page = context.pages[0]
2920

‎examples/playwright_contexts.py‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,7 @@
55
from playwright.sync_api import Cookie, Browser, Playwright, sync_playwright
66

77

8-
from examples import (
9-
BROWSERBASE_API_KEY,
10-
BROWSERBASE_PROJECT_ID,
11-
BROWSERBASE_CONNECT_URL,
12-
bb,
13-
)
8+
from examples import BROWSERBASE_PROJECT_ID, bb
149
from browserbase.types.session_create_params import (
1510
BrowserSettings,
1611
BrowserSettingsContext,
@@ -61,9 +56,7 @@ def run(playwright: Playwright) -> None:
6156

6257
# Step 3: Populates and persists the context
6358
print(f"Populating context {context_id} during session {session_id}")
64-
connect_url = (
65-
f"{BROWSERBASE_CONNECT_URL}?sessionId={session_id}&apiKey={BROWSERBASE_API_KEY}"
66-
)
59+
connect_url = session.connect_url
6760
browser = playwright.chromium.connect_over_cdp(connect_url)
6861
page = browser.contexts[0].pages[0]
6962

@@ -110,9 +103,7 @@ def run(playwright: Playwright) -> None:
110103

111104
# Step 5: Uses context to find previous state
112105
print(f"Reusing context {context_id} during session {session_id}")
113-
connect_url = (
114-
f"{BROWSERBASE_CONNECT_URL}?sessionId={session_id}&apiKey={BROWSERBASE_API_KEY}"
115-
)
106+
connect_url = session.connect_url
116107
browser = playwright.chromium.connect_over_cdp(connect_url)
117108
page = browser.contexts[0].pages[0]
118109

‎examples/playwright_downloads.py‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,7 @@
55
from playwright.sync_api import Playwright, sync_playwright
66

77

8-
from examples import (
9-
BROWSERBASE_API_KEY,
10-
BROWSERBASE_PROJECT_ID,
11-
BROWSERBASE_CONNECT_URL,
12-
bb,
13-
)
8+
from examples import BROWSERBASE_PROJECT_ID, bb
149

1510
download_re = re.compile(r"sandstorm-(\d{13})+\.mp3")
1611

@@ -27,9 +22,7 @@ def run(playwright: Playwright) -> None:
2722
assert session.status == "RUNNING", f"Session status is {session.status}"
2823

2924
# Connect to the remote session
30-
connect_url = (
31-
f"{BROWSERBASE_CONNECT_URL}?sessionId={session.id}&apiKey={BROWSERBASE_API_KEY}"
32-
)
25+
connect_url = session.connect_url
3326
browser = playwright.chromium.connect_over_cdp(connect_url)
3427
context = browser.contexts[0]
3528
page = context.pages[0]

‎examples/playwright_extensions.py‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@
77
from playwright.sync_api import Page, Playwright, sync_playwright
88

99
from examples import (
10-
BROWSERBASE_API_KEY,
1110
BROWSERBASE_PROJECT_ID,
12-
BROWSERBASE_CONNECT_URL,
1311
bb,
1412
)
1513
from browserbase.types import Extension, SessionCreateResponse
@@ -100,9 +98,7 @@ def run(playwright: Playwright) -> None:
10098
extension_id=extension.id,
10199
)
102100

103-
browser = playwright.chromium.connect_over_cdp(
104-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session.id}"
105-
)
101+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
106102
context = browser.contexts[0]
107103
page = context.pages[0]
108104
check_for_message(page, expected_message)
@@ -116,9 +112,7 @@ def run(playwright: Playwright) -> None:
116112
proxies=True,
117113
)
118114

119-
browser = playwright.chromium.connect_over_cdp(
120-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session_with_proxy.id}"
121-
)
115+
browser = playwright.chromium.connect_over_cdp(session_with_proxy.connect_url)
122116
context = browser.contexts[0]
123117
page = context.pages[0]
124118

‎examples/playwright_proxy.py‎

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
from examples import (
66
BROWSERBASE_API_KEY,
77
BROWSERBASE_PROJECT_ID,
8-
BROWSERBASE_CONNECT_URL,
98
bb,
109
)
1110

@@ -26,9 +25,7 @@ def check_proxy_bytes(session_id: str) -> None:
2625
def run_enable_via_create_session(playwright: Playwright) -> None:
2726
session = bb.sessions.create(project_id=BROWSERBASE_PROJECT_ID, proxies=True)
2827

29-
browser = playwright.chromium.connect_over_cdp(
30-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session.id}"
31-
)
28+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
3229

3330
context = browser.contexts[0]
3431
page = context.pages[0]
@@ -45,9 +42,7 @@ def run_enable_via_create_session(playwright: Playwright) -> None:
4542
def run_enable_via_querystring_with_created_session(playwright: Playwright) -> None:
4643
session = bb.sessions.create(project_id=BROWSERBASE_PROJECT_ID, proxies=True)
4744

48-
browser = playwright.chromium.connect_over_cdp(
49-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session.id}&enableProxy=true"
50-
)
45+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
5146

5247
context = browser.contexts[0]
5348
page = context.pages[0]
@@ -84,9 +79,7 @@ def run_geolocation_country(playwright: Playwright) -> None:
8479
],
8580
)
8681

87-
browser = playwright.chromium.connect_over_cdp(
88-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session.id}"
89-
)
82+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
9083

9184
context = browser.contexts[0]
9285
page = context.pages[0]
@@ -113,9 +106,7 @@ def run_geolocation_state(playwright: Playwright) -> None:
113106
],
114107
)
115108

116-
browser = playwright.chromium.connect_over_cdp(
117-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session.id}"
118-
)
109+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
119110

120111
context = browser.contexts[0]
121112
page = context.pages[0]
@@ -143,9 +134,7 @@ def run_geolocation_american_city(playwright: Playwright) -> None:
143134
],
144135
)
145136

146-
browser = playwright.chromium.connect_over_cdp(
147-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session.id}"
148-
)
137+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
149138

150139
context = browser.contexts[0]
151140
page = context.pages[0]
@@ -172,9 +161,7 @@ def run_geolocation_non_american_city(playwright: Playwright) -> None:
172161
],
173162
)
174163

175-
browser = playwright.chromium.connect_over_cdp(
176-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session.id}"
177-
)
164+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
178165

179166
context = browser.contexts[0]
180167
page = context.pages[0]

‎examples/playwright_upload.py‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,7 @@
22

33
from playwright.sync_api import Playwright, sync_playwright
44

5-
from examples import (
6-
BROWSERBASE_API_KEY,
7-
BROWSERBASE_PROJECT_ID,
8-
BROWSERBASE_CONNECT_URL,
9-
bb,
10-
)
5+
from examples import BROWSERBASE_PROJECT_ID, bb
116

127
PATH_TO_UPLOAD = Path.cwd() / "examples" / "packages" / "logo.png"
138

@@ -16,13 +11,8 @@ def run(playwright: Playwright) -> None:
1611
# Create a session
1712
session = bb.sessions.create(project_id=BROWSERBASE_PROJECT_ID)
1813

19-
# Construct the URL
20-
url = (
21-
f"{BROWSERBASE_CONNECT_URL}?apiKey={BROWSERBASE_API_KEY}&sessionId={session.id}"
22-
)
23-
2414
# Connect to the browser
25-
browser = playwright.chromium.connect_over_cdp(url)
15+
browser = playwright.chromium.connect_over_cdp(session.connect_url)
2616
context = browser.contexts[0]
2717
page = context.pages[0]
2818

0 commit comments

Comments
 (0)