Skip to content

fix invalid container #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xtang wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix invalid container #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
971d9a8
Always select container when config.container is set
xtang Jul 26, 2014
694fbda
Remove duplicate container assignment
xtang Jul 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ factory('btfModal', function ($animate, $compile, $rootScope, $controller, $q, $
var template = config.template,
controller = config.controller || angular.noop,
controllerAs = config.controllerAs,
container = angular.element(config.container || document.body),
element = null,
container = angular.element(document.body),
Copy link
Owner

@btford btford Jul 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you're changing this logic, you should remove the other container = angular.element(config.container || document.body),

Copy link
Author

@xtang xtang Jul 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot that:(

html,
scope;

Expand Down Expand Up @@ -48,6 +48,9 @@ factory('btfModal', function ($animate, $compile, $rootScope, $controller, $q, $
if (element.length === 0) {
throw new Error('The template contains no elements; you need to wrap text nodes')
}
if (config.container) {
container = angular.element(config.container);
}
$animate.enter(element, container);
scope = $rootScope.$new();
if (locals) {
Expand Down