Skip to content

chore: fmt import sort #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btravers merged 1 commit into from
Jan 22, 2026
Merged

chore: fmt import sort #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .oxfmtrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{
"$schema": "./node_modules/oxfmt/configuration_schema.json",
"ignorePatterns": ["package.json", "pnpm-lock.yaml"]
"ignorePatterns": ["package.json", "pnpm-lock.yaml"],
"organizeImports": {
"sortImports": true,
"separateGroups": true
}
}
1 change: 0 additions & 1 deletion .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"$schema": "./node_modules/oxlint/configuration_schema.json",
"rules": {
"sort-imports": "off",
"@typescript-eslint/no-explicit-any": "error"
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the explicit sort-imports: off means whether oxlint enforces import ordering now depends on oxlint defaults. If sort-imports is enabled, this can also make the pre-commit hook flaky because lefthook.yml runs format and lint in parallel, so lint may run before oxfmt has re-ordered imports. Consider either explicitly configuring sort-imports here (to match the intended source of truth) or making the hook run lint after formatting.

Suggested change
"@typescript-eslint/no-explicit-any": "error"
"@typescript-eslint/no-explicit-any": "error",
"sort-imports": "off"

Copilot uses AI. Check for mistakes.
}
}
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ pnpm test # Run unit tests
pnpm test:integration # Run integration tests (requires Docker)
pnpm typecheck # Type check all packages
pnpm lint # Run oxlint
pnpm format # Format with oxfmt
pnpm format # Format with oxfmt (import sorting)
pnpm format --check # Check formatting
pnpm knip # Check for unused exports/dependencies
```
Expand Down
Loading