Skip to content

Commit 7d0fdf3

Browse files
jjbustamanteclaude
andauthored
fix: migrate Windows CI testing from Equinix LCOW to GitHub-hosted runners (#2506)
This commit addresses issue #2505 by removing the dependency on the Equinix Metal self-hosted Windows LCOW runner, which is being sunset. Changes: - Replaced windows-lcow config with windows config using windows-latest runner - Set NO_DOCKER=true for Windows testing (GitHub runners don't support LCOW) - Added step to install Make via Chocolatey for Windows runner - Windows tests will run unit tests without Docker-dependent tests - Maintains pack.exe artifact generation for Chocolatey distribution The new configuration: - Runs basic pack CLI tests on Windows to validate it works - Does not run Docker/LCOW tests (requires nested virtualization) - Ensures Windows binaries continue to be built for releases - Uses GitHub-hosted infrastructure instead of self-hosted Equinix Metal Resolves #2505 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Juan Bustamante <bustamantejj@gmail.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent dc9220d commit 7d0fdf3

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

.github/workflows/build.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
strategy:
2121
fail-fast: false
2222
matrix:
23-
config: [macos, linux, windows-lcow]
23+
config: [macos, linux, windows]
2424
include:
2525
- config: macos
2626
# since macos-14 the latest runner is arm64
@@ -33,10 +33,10 @@ jobs:
3333
runner: ubuntu-latest
3434
no_docker: "false"
3535
pack_bin: pack
36-
- config: windows-lcow
36+
- config: windows
3737
os: windows
38-
runner: [self-hosted, windows, lcow]
39-
no_docker: "false"
38+
runner: windows-latest
39+
no_docker: "true"
4040
pack_bin: pack.exe
4141
runs-on: ${{ matrix.runner }}
4242
env:
@@ -84,6 +84,9 @@ jobs:
8484
echo "GOPATH=$(go env GOPATH)"| Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
8585
echo "$(go env GOPATH)\bin" | Out-File -FilePath $Env:GITHUB_PATH -Encoding utf8 -Append
8686
shell: powershell
87+
- name: Install Make on Windows
88+
if: runner.os == 'Windows'
89+
run: choco install make -y
8790
- name: Verify
8891
run: make verify
8992
- name: Test

0 commit comments

Comments
 (0)