caddytls: panic when using tls.ca_pool.source.http -> tls.ca (#7393)

Zenexer · web-flow · commit 6a4296b1a45d · 2025-12-11T19:27:15.000Z
diff --git a/modules/caddytls/capools.go b/modules/caddytls/capools.go
@@ -502,7 +502,7 @@ func (t *TLSConfig) unmarshalCaddyfile(d *caddyfile.Dispenser) error {
 // If there is no custom TLS configuration, a nil config may be returned.
 // copied from with minor modifications: modules/caddyhttp/reverseproxy/httptransport.go
 func (t *TLSConfig) makeTLSClientConfig(ctx caddy.Context) (*tls.Config, error) {
-	repl := ctx.Value(caddy.ReplacerCtxKey).(*caddy.Replacer)
+	repl, _ := ctx.Value(caddy.ReplacerCtxKey).(*caddy.Replacer)
 	if repl == nil {
 		repl = caddy.NewReplacer()
 	}

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@ func (t TLSConfig) unmarshalCaddyfile(d caddyfile.Dispenser) error {`
`502`	`502`	`// If there is no custom TLS configuration, a nil config may be returned.`
`503`	`503`	`// copied from with minor modifications: modules/caddyhttp/reverseproxy/httptransport.go`
`504`	`504`	`func (t TLSConfig) makeTLSClientConfig(ctx caddy.Context) (tls.Config, error) {`
`505`		`- repl := ctx.Value(caddy.ReplacerCtxKey).(*caddy.Replacer)`
	`505`	`+ repl, _ := ctx.Value(caddy.ReplacerCtxKey).(*caddy.Replacer)`
`506`	`506`	`if repl == nil {`
`507`	`507`	`repl = caddy.NewReplacer()`
`508`	`508`	`}`