Skip to content

Fix the list of rss feed items in dark mode #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
can3p merged 1 commit into from
Jan 23, 2026
Merged

Fix the list of rss feed items in dark mode #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,28 @@ Configured in `NewParser()`:
3. Register in `NewParser()` via `nodeRenderers` slice
4. Conditionally add based on view type if needed

## Dark Mode Styling

### Architecture
Located in `/Users/dima/code/pcom/cmd/web/client/scss/_dark-mode.scss`:
- Uses Bootstrap 5.3+ color modes with `data-bs-theme="dark"` and `prefers-color-scheme` media query
- All styles defined in `@mixin dark-mode-styles` for reusability

### CSS Variable Override Pattern
**Override Bootstrap component variables by scoping them within component selectors:**
```scss
.list-group {
--bs-list-group-bg: #2d2d2d;
--bs-list-group-border-color: #404040;
--bs-list-group-color: var(--text-color);
}
```

**Do NOT define ad-hoc colors directly on elements** - always use Bootstrap's CSS variables to ensure proper inheritance and theming.

## File Locations
- HTML Templates: `/Users/dima/code/pcom/cmd/web/client/html/`
- JavaScript: `/Users/dima/code/pcom/cmd/web/client/js/`
- Main JS entry: `/Users/dima/code/pcom/cmd/web/client/js/index.js`
- Markdown package: `/Users/dima/code/pcom/pkg/markdown/`
- Dark mode styles: `/Users/dima/code/pcom/cmd/web/client/scss/_dark-mode.scss`
8 changes: 8 additions & 0 deletions cmd/web/client/scss/_dark-mode.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,14 @@
border-color: #404040;
color: #6c757d;
}

// List groups
.list-group {
--bs-list-group-bg: #2d2d2d;
--bs-list-group-border-color: #404040;
--bs-list-group-color: var(--text-color);
--bs-list-group-action-hover-bg: #353535;
}
}

// Apply dark mode styles manually with data-bs-theme="dark"
Expand Down
Loading