-
Notifications
You must be signed in to change notification settings - Fork 190
wip: feat(Tiered List): add media (images/videos) to the Tiered List pattern #5503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
muhammad-ali-pk
wants to merge
9
commits into
main
Choose a base branch
from
feat-tiered-list-with-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7eb67de
feat: add image to tiered list (full width or default)
muhammad-ali-pk 23bebb0
Addressed review comments
muhammad-ali-pk 0722717
All images within tiered lists to have p-image-container--cinematic a…
muhammad-ali-pk 5d37f7b
resolve rebases
jmuzina 938d051
Add default/full-width/video use case, many examples for test coverag…
jmuzina 1aca751
tweak docs
jmuzina 2696872
Tweak tiered list example titles
jmuzina f428294
wip
jmuzina 2f32fec
initial update to test that the _attrs update is working
jmuzina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| canonicalwebteam.flask-base==2.5.0 | ||
| canonicalwebteam.templatefinder==1.0.0 | ||
| canonicalwebteam.search==2.1.1 | ||
| canonicalwebteam.image-template==1.5.0 | ||
| canonicalwebteam.image-template==1.6.0 | ||
| mistune==0.8.4 | ||
| pyyaml==6.0.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 93 additions & 0 deletions
93
...-list/50-50-desktop-with-description-cta-with-default-width-image-before-description.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| {% extends "_layouts/examples.html" %} | ||
| {% from "_macros/vf_tiered-list.jinja" import vf_tiered_list %} | ||
|
|
||
| {% block title %}Tiered list / 50/50 on desktop with description CTA / With default width image before description{% endblock %} | ||
|
|
||
| {% block standalone_css %}patterns_all{% endblock %} | ||
|
|
||
| {% block content %} | ||
| {%- call(slot) vf_tiered_list(is_description_full_width_on_desktop=false, is_list_full_width_on_tablet=true, media_placement="before_description") -%} | ||
| {%- if slot == 'title' -%} | ||
| <h2>H2 - up to two lines; ideally one.</h2> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == "image" -%} | ||
| <img class="p-image-container__image" src="https://assets.ubuntu.com/v1/98b645b4-assessment.png" width="800" alt=""> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'description' -%} | ||
| <p>A <a href="#">private cloud</a> provides organisations with on-demand | ||
| compute, storage and other resources that can be accessed over the network | ||
| and that are reserved exclusively for them - either in their own data centre | ||
| or via a 3rd party.</p> | ||
|
|
||
| <!-- Optional CTA block --> | ||
| <div class="p-cta-block"> | ||
| <a href="#">Link to blog post ›</a> | ||
| </div> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_1' -%} | ||
| <h3 class="p-heading--5">Rich portfolio of products</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_1' -%} | ||
| <p>Resell the full range of Canonical’s portfolio of private and public | ||
| cloud products: OpenStack, Kubernetes, IoT, support, security and | ||
| compliance for Ubuntu.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_2' -%} | ||
| <h3 class="p-heading--5">Sales enablement</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_2' -%} | ||
| <p>Canonical can help train your field sales and presales teams and | ||
| provide you with sales collateral and permission to use the Canonical | ||
| and Ubuntu trademarks in your own materials.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_3' -%} | ||
| <h3 class="p-heading--5">Access to Canonical partner portal</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_3' -%} | ||
| <p>We host a partner portal with product and solutions collaterals, agreed | ||
| pricing, incentives and a deal registration system.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_4' -%} | ||
| <h3 class="p-heading--5">Training and certification</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_4' -%} | ||
| <p>Gain access to technology that is the foundation for digital | ||
| transformation and expand your business through marketing support and | ||
| alignment with a trusted brand</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_5' -%} | ||
| <h3 class="p-heading--5">Technical enablement</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_5' -%} | ||
| <p>We provide in-depth technical training for your customer engineering | ||
| teams with access to technical resources for your labs and customer | ||
| engagements.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_6' -%} | ||
| <h3 class="p-heading--5">Go to market with Canonical</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_6' -%} | ||
| <p>Working with our dedicated partner team, get new joint marketing | ||
| opportunities and lead generation.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'cta' -%} | ||
| <a href="#" class="p-button">Learn more</a> | ||
| <a href="#">Contact us ›</a> | ||
| {%- endif -%} | ||
| {%- endcall -%} | ||
| {% endblock %} |
93 changes: 93 additions & 0 deletions
93
...les/patterns/tiered-list/50-50-desktop-with-description-cta-with-default-width-image.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| {% extends "_layouts/examples.html" %} | ||
| {% from "_macros/vf_tiered-list.jinja" import vf_tiered_list %} | ||
|
|
||
| {% block title %}Tiered list / 50/50 on desktop with description CTA / With default width image{% endblock %} | ||
|
|
||
| {% block standalone_css %}patterns_all{% endblock %} | ||
|
|
||
| {% block content %} | ||
| {%- call(slot) vf_tiered_list(is_description_full_width_on_desktop=false, is_list_full_width_on_tablet=true) -%} | ||
| {%- if slot == 'title' -%} | ||
| <h2>H2 - up to two lines; ideally one.</h2> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == "image" -%} | ||
| <img class="p-image-container__image" src="https://assets.ubuntu.com/v1/98b645b4-assessment.png" width="800" alt=""> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'description' -%} | ||
| <p>A <a href="#">private cloud</a> provides organisations with on-demand | ||
| compute, storage and other resources that can be accessed over the network | ||
| and that are reserved exclusively for them - either in their own data centre | ||
| or via a 3rd party.</p> | ||
|
|
||
| <!-- Optional CTA block --> | ||
| <div class="p-cta-block"> | ||
| <a href="#">Link to blog post ›</a> | ||
| </div> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_1' -%} | ||
| <h3 class="p-heading--5">Rich portfolio of products</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_1' -%} | ||
| <p>Resell the full range of Canonical’s portfolio of private and public | ||
| cloud products: OpenStack, Kubernetes, IoT, support, security and | ||
| compliance for Ubuntu.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_2' -%} | ||
| <h3 class="p-heading--5">Sales enablement</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_2' -%} | ||
| <p>Canonical can help train your field sales and presales teams and | ||
| provide you with sales collateral and permission to use the Canonical | ||
| and Ubuntu trademarks in your own materials.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_3' -%} | ||
| <h3 class="p-heading--5">Access to Canonical partner portal</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_3' -%} | ||
| <p>We host a partner portal with product and solutions collaterals, agreed | ||
| pricing, incentives and a deal registration system.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_4' -%} | ||
| <h3 class="p-heading--5">Training and certification</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_4' -%} | ||
| <p>Gain access to technology that is the foundation for digital | ||
| transformation and expand your business through marketing support and | ||
| alignment with a trusted brand</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_5' -%} | ||
| <h3 class="p-heading--5">Technical enablement</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_5' -%} | ||
| <p>We provide in-depth technical training for your customer engineering | ||
| teams with access to technical resources for your labs and customer | ||
| engagements.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_title_6' -%} | ||
| <h3 class="p-heading--5">Go to market with Canonical</h3> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'list_item_description_6' -%} | ||
| <p>Working with our dedicated partner team, get new joint marketing | ||
| opportunities and lead generation.</p> | ||
| {%- endif -%} | ||
|
|
||
| {%- if slot == 'cta' -%} | ||
| <a href="#" class="p-button">Learn more</a> | ||
| <a href="#">Contact us ›</a> | ||
| {%- endif -%} | ||
| {%- endcall -%} | ||
| {% endblock %} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.