Silent buffer modifications interefere with org-element-cache

[yantar92]

Hi,

(with-silent-modifications ... (insert ...) ...) in valign--table-2 prevents org-mode from tracking buffer changes thus breaking parser AST cache. See https://list.orgmode.org/CAGVe720Zom3zfCJODvDrb+WEgEoQ-9nddEWjJ67_Db-VSr=-9g@mail.gmail.com/T/#u

Can you please not use with-silent-modifications when actually modifying the buffer text?

valign/valign.el

Line 903 in be82f60

(insert (valign-box-char 'h ucharset))

[casouri]

Sorry for the delay. It would be equally annoying if prettifying a table changes the buffer's modification status, and it would be confusing, too. I might be able to not insert that character with a new function introduce in Emacs 28. Let me experiment with that and get back to you. let me know if you have some other ideas, thanks.

[yantar92]

You may use display properties. Built-in Org formatter should aways leave spaces around table cells to apply the display properties to.

[casouri]

It's not that. I need to know the pixel width of that character in the current buffer and window. Believe it or not, the only way to measure that is to insert the character, measure it, and remove the character. I remember seeing a new function that allow me to measure that without inserting the character, hopefully that function spares me of this ugly hack :-)

[yantar92]

I see. Take a look at org-string-width

[yantar92]

After discussion with emacs-devs, we have changed the Org relevant code. The issue should no longer be triggerred by valign.

[casouri]

Thanks, I'll keep this open to remind me of improving valign.