Skip to content

Delaying DOM usage until invocation #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iambalaam merged 1 commit into from
Jan 7, 2026
Merged

Delaying DOM usage until invocation #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/javascript/src/AudioPlayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Media, MediaClientConfig } from './types/CogsClientMessage';
const DEBUG = false;

// Check an iOS-only property (See https://developer.mozilla.org/en-US/docs/Web/API/Navigator#non-standard_properties)
const IS_IOS = typeof (navigator as { standalone?: boolean }).standalone !== 'undefined';
const IS_IOS = typeof navigator !== 'undefined' && typeof (navigator as { standalone?: boolean }).standalone !== 'undefined';

interface HowlWithHTMLSounds extends Howl {
_html5?: unknown;
Expand Down
6 changes: 2 additions & 4 deletions packages/javascript/src/VideoPlayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ type EventTypes = {
videoClipState: MediaClipStateMessage;
};

const DEFAULT_PARENT_ELEMENT = document.body;

export default class VideoPlayer {
private eventTarget = new EventTarget();
private globalVolume = 1;
Expand All @@ -28,7 +26,7 @@ export default class VideoPlayer {
constructor(
// eslint-disable-next-line @typescript-eslint/no-explicit-any
private cogsConnection: CogsConnection<any>,
parentElement: HTMLElement = DEFAULT_PARENT_ELEMENT,
parentElement: HTMLElement = document.body,
) {
this.parentElement = parentElement;

Expand Down Expand Up @@ -98,7 +96,7 @@ export default class VideoPlayer {
}

resetParentElement(): void {
this.setParentElement(DEFAULT_PARENT_ELEMENT);
this.setParentElement(document.body);
}

setGlobalVolume(globalVolume: number): void {
Expand Down