-
Notifications
You must be signed in to change notification settings - Fork 22
Open
Labels
enhancementNew feature or requestNew feature or requeststatus - PR WelcomeThis issue is well-defined and community PRs are welcomeThis issue is well-defined and community PRs are welcome
Description
Currently, binary-install assumes that uninstalling should remove the entire directory from the user's machine, however some libraries may have application-specific code in that directory. If that is the case, they may want to give users the choice of whether or not they want to remove application-specific code, or just the binary.
binary-install should remove the entire directory by default, but should allow library consumers to toggle the feature where the user is prompted to either remove the entire directory or just the binary.
current code in uninstall that should remain the default
if (existsSync(this._getInstallDirectory())) {
rimraf.sync(this.installDirectory);
console.log(
`${this.name ? this.name : "Your package"} has been uninstalled`
);
}if the user passes option.uninstallPrompt = true
"Would you like to remove all of your data associated with ${this.name}`? (y/n)
if y -> use existing default code
if n -> fs.unlink(this._getBinaryPath())
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requeststatus - PR WelcomeThis issue is well-defined and community PRs are welcomeThis issue is well-defined and community PRs are welcome