Skip to content

Commit 6918d99

Browse files
committed
Enable_websockets ist true by default
1 parent a06d5a2 commit 6918d99

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

jobs/gorouter/spec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ properties:
258258
router.route_services.enable_websockets:
259259
description: |
260260
Enable websocket connections for application routes bound to Route Services.
261-
default: false
261+
default: true
262262
router.route_services.cert_chain:
263263
description: Certificate chain used for client authentication to TLS-registered route services. In PEM format.
264264
router.route_services.private_key:

spec/gorouter_templates_spec.rb

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@
229229
'cert_chain' => ROUTE_SERVICES_CLIENT_TEST_CERT,
230230
'private_key' => ROUTE_SERVICES_CLIENT_TEST_KEY,
231231
'strict_signature_validation' => false,
232-
'enable_websockets' => false,
232+
'enable_websockets' => true,
233233
},
234234
'frontend_idle_timeout' => 5,
235235
'ip_local_port_range' => '1024 65535',
@@ -921,18 +921,26 @@
921921
end
922922
end
923923
context 'when enable_websockets not set' do
924-
it 'defaults to false' do
925-
expect(parsed_yaml['route_services']['enable_websockets']).to eq(false)
924+
it 'defaults to true' do
925+
expect(parsed_yaml['route_services']['enable_websockets']).to eq(true)
926926
end
927927
end
928-
context 'when enable_websockets enabled' do
928+
context 'when enable_websockets is enabled' do
929929
before do
930930
deployment_manifest_fragment['router']['route_services']['enable_websockets'] = true
931931
end
932932
it 'parses to true' do
933933
expect(parsed_yaml['route_services']['enable_websockets']).to eq(true)
934934
end
935935
end
936+
context 'when enable_websockets is disabled' do
937+
before do
938+
deployment_manifest_fragment['router']['route_services']['enable_websockets'] = false
939+
end
940+
it 'parses to true' do
941+
expect(parsed_yaml['route_services']['enable_websockets']).to eq(false)
942+
end
943+
end
936944
end
937945

938946
describe 'backends' do

0 commit comments

Comments
 (0)