-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
There appears to be a naming and/or consistency issue with the URLs when trying to download specific versions of the CLI via cli-version arg.
The pattern where the filename is cloudsmith.pyz works for some versions but not others:
Example:
- Works - https://dl.cloudsmith.io/public/cloudsmith/cli-zipapp/raw/names/cloudsmith-cli/versions/1.10.3/cloudsmith.pyz
- Doesn't work - https://dl.cloudsmith.io/public/cloudsmith/cli-zipapp/raw/names/cloudsmith-cli/versions/1.11.1/cloudsmith.pyz
However, the opposite is true for including the version in the filename, ie cloudsmith-1.11.1.pyz
Example:
- Works - https://dl.cloudsmith.io/public/cloudsmith/cli-zipapp/raw/names/cloudsmith-cli/versions/1.11.1/cloudsmith-1.11.1.pyz
- Doesn't work - https://dl.cloudsmith.io/public/cloudsmith/cli-zipapp/raw/names/cloudsmith-cli/versions/1.10.3/cloudsmith-1.10.3.pyz
Right now if you download the latest, the redirect includes the version in the redirected URL
$ curl -Ls -w %{url_effective} -o /dev/null https://dl.cloudsmith.io/public/cloudsmith/cli-zipapp/raw/names/cloudsmith-cli/versions/latest/cloudsmith.pyz
https://dl.cloudsmith.io/public/cloudsmith/cli-zipapp/raw/names/cloudsmith-cli/versions/1.11.1/cloudsmith-1.11.1.pyz
The downloadSpecificRelease function currently expects to download the file without the version in the URL. Does this code need to be updated? I'd be happy to send up a PR but am not sure how you'd go about coding it as things stand.
Metadata
Metadata
Assignees
Labels
No labels