Response payload should be checked

[cmungall]

Sometimes the response payload is:

{
  "message": "Problems parsing JSON",
  "documentation_url": "https://developer.github.com/v3"
}

this is currently not detected.

We expect something like this:

{
  "id": 224873,
  "status": "pending",
  "url": "https://api.github.com/repos/geneontology/go-ontology/import/issues/224873",
  "import_issues_url": "https://api.github.com/repos/geneontology/go-ontology/import/issues",
  "repository_url": "https://api.github.com/repos/geneontology/go-ontology",
  "created_at": "2015-07-25T11:38:19-07:00",
  "updated_at": "2015-07-25T11:38:19-07:00"
}

even this is no guarantee of success - the URL should be checked

[jamesaoverton]

I ran this for OBI, and it worked pretty well.

About 2% (16/829) of issues failed. A GET on the import_issues_url gives a full report. The failures look like this:

{
  "id": 1134207,
  "status": "failed",
  "url": "https://api.github.com/repos/obi-ontology/obi/import/issues/1134207",
  "import_issues_url": "https://api.github.com/repos/obi-ontology/obi/import/issues",
  "repository_url": "https://api.github.com/repos/obi-ontology/obi",
  "created_at": "2017-03-06T10:33:33-05:00",
  "updated_at": "2017-03-06T10:34:41-05:00",
  "errors": [
    {
      "location": "n/a",
      "resource": "Internal Error",
      "field": null,
      "value": "ab54675b7c44e16e744ff85e938f0ffc3750e26d",
      "code": "error"
    }
  ]
},

All failures were marked "Internal Error", which is not very helpful.

Figuring out which ones failed and retrying them looks tedious, so I don't know if I'll bother. I haven't looked for a pattern.